◐ Shell
reader mode source ↗
Skip to content

gh-104146: Purge dead code from Argument Clinic#104680

Merged
AlexWaygood merged 3 commits into
python:mainfrom
erlend-aasland:clinic/the-purge
May 20, 2023
Merged

gh-104146: Purge dead code from Argument Clinic#104680
AlexWaygood merged 3 commits into
python:mainfrom
erlend-aasland:clinic/the-purge

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The following local variables were assigned but never used:

  • line 551: result
  • line 1341: groups
  • line 1431: default_return_converter
  • line 1529: ignore_self
  • line 1809: input_checksum
  • line 4224: new'

@erlend-aasland
pythongh-104146: Purge dead code from Argument Clinic …
9395dd7 
The following local variables were assigned but never used:

- line 551:  result
- line 1341: groups
- line 1431: default_return_converter
- line 1529: ignore_self
- line 1809: input_checksum
- line 4224: new'
@bedevere-bot bedevere-bot mentioned this pull request May 20, 2023
Closed
@erlend-aasland erlend-aasland linked an issue May 20, 2023 that may be closed by this pull request
Remove dead code from clinic.py #104146
Closed
@AlexWaygood

AlexWaygood commented May 20, 2023

Copy link
Copy Markdown
Member

Would you be interested in possibly running pyflakes on Tools/clinic/ in CI, to catch this kind of thing in the future? It's a linter that tries extremely hard to have 0 false positives, and didn't have any hits on Tools/clinic/ other than the ones that are being fixed here

@erlend-aasland

erlend-aasland commented May 20, 2023

Copy link
Copy Markdown
Contributor Author

Would you be interested in possibly running pyflakes on Tools/clinic/ in CI, to catch this kind of thing in the future? It's a linter that tries extremely hard to have 0 false positives, and didn't have any hits on Tools/clinic/ other than the ones that are being fixed here

I think that's a good idea. Others might disagree :)

@AlexWaygood

AlexWaygood commented May 20, 2023

Copy link
Copy Markdown
Member

I can open an issue and we can see if anybody objects!

@AlexWaygood AlexWaygood enabled auto-merge (squash) May 20, 2023 10:28
@AlexWaygood AlexWaygood merged commit ae147d0 into python:main May 20, 2023
@erlend-aasland erlend-aasland deleted the clinic/the-purge branch May 20, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dead code from clinic.py

3 participants

@erlend-aasland @AlexWaygood @bedevere-bot