◐ Shell
reader mode source ↗
Skip to content

GH-101291: Avoid using macros with casts in low-level long API.#104742

Merged
iritkatriel merged 1 commit into
python:mainfrom
faster-cpython:fix-long-asserts
May 22, 2023
Merged

GH-101291: Avoid using macros with casts in low-level long API.#104742
iritkatriel merged 1 commit into
python:mainfrom
faster-cpython:fix-long-asserts

Conversation

@markshannon

@markshannon markshannon commented May 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Stick to inline functions and plain assert to avoid losing constness.
Fixes C++ compiler warnings.
See #101685 (comment)

@bedevere-bot bedevere-bot mentioned this pull request May 22, 2023
Open
@markshannon

markshannon commented May 22, 2023

Copy link
Copy Markdown
Member Author

@rwgk can you confirm that this fixes the pybind11 compilation issue?

@rwgk

rwgk commented May 22, 2023

Copy link
Copy Markdown

@rwgk can you confirm that this fixes the pybind11 compilation issue?

Yes, confirmed! Thanks for the quick fix!

Building all pybind11 unit tests works again.

For completeness: I'm currently unable to run the full suite of pybind11 unit tests b/o an unrelated problem (#103912 (comment)).

@iritkatriel iritkatriel merged commit e295d86 into python:main May 22, 2023
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label May 22, 2023
@miss-islington

miss-islington commented May 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@markshannon @miss-islington
pythonGH-101291: Avoid using macros with casts in low-level long API. (… …
fd90299 
…pythonGH-104742)

(cherry picked from commit e295d86)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot

bedevere-bot commented May 22, 2023

Copy link
Copy Markdown

GH-104759 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 22, 2023
@JelleZijlstra

JelleZijlstra commented May 22, 2023

Copy link
Copy Markdown
Member

(Backporting since this fixes compiler warnings from a recent change, so this counts as a bug fix.)

JelleZijlstra pushed a commit that referenced this pull request May 23, 2023
@miss-islington @markshannon
[3.12] GH-101291: Avoid using macros with casts in low-level long API. ( …
e43fbbd 
GH-104742) (#104759)

(cherry picked from commit e295d86)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
@markshannon markshannon deleted the fix-long-asserts branch September 26, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markshannon @rwgk @miss-islington @bedevere-bot @JelleZijlstra @iritkatriel