◐ Shell
reader mode source ↗
Skip to content

Improve test coverage for is_typeddict#104884

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:istdtests
May 24, 2023
Merged

Improve test coverage for is_typeddict#104884
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:istdtests

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member

In particular, it's important to test that is_typeddict(TypedDict)
returns False.

@JelleZijlstra
Improve test coverage for TypedDict …
15e70c1 
In particular, it's important to test that is_typeddict(TypedDict)
returns False.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels May 24, 2023
@JelleZijlstra JelleZijlstra changed the title Improve test coverage for TypedDict May 24, 2023
@JelleZijlstra JelleZijlstra merged commit 1497607 into python:main May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the istdtests branch May 24, 2023 18:46
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 1497607a8e99f1103c40368dd5f9057f0146a520 3.12

@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104888 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@JelleZijlstra @miss-islington
Improve test coverage for is_typeddict (pythonGH-104884) …
8c28737 
In particular, it's important to test that is_typeddict(TypedDict)
returns False.
(cherry picked from commit 1497607)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 24, 2023
@JelleZijlstra JelleZijlstra added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104889 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@JelleZijlstra @miss-islington
Improve test coverage for is_typeddict (pythonGH-104884) …
01a1230 
In particular, it's important to test that is_typeddict(TypedDict)
returns False.
(cherry picked from commit 1497607)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
@AlexWaygood

AlexWaygood commented May 24, 2023

Copy link
Copy Markdown
Member

We should probably backport these to typing_extensions too

@JelleZijlstra

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member Author

Maybe we should get Miss Islington to do that too :)

AlexWaygood pushed a commit that referenced this pull request May 24, 2023
@miss-islington @JelleZijlstra
[3.12] Improve test coverage for is_typeddict (GH-104884) (#104889) …
3d91d03 
Improve test coverage for is_typeddict (GH-104884)

In particular, it's important to test that is_typeddict(TypedDict)
returns False.
(cherry picked from commit 1497607)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra added a commit that referenced this pull request May 24, 2023
@miss-islington @JelleZijlstra
[3.11] Improve test coverage for is_typeddict (GH-104884) (#104888) …
5e91167 
In particular, it's important to test that is_typeddict(TypedDict)
returns False.
(cherry picked from commit 1497607)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
@JelleZijlstra JelleZijlstra restored the istdtests branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip issue skip news tests Tests in the Lib/test dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra @miss-islington @bedevere-bot @AlexWaygood