{{ message }}
GH-104996: Defer joining of pathlib.PurePath() arguments.#104999
Merged
barneygale merged 4 commits intoJun 7, 2023
Merged
Conversation
Contributor
Sorry, something went wrong.
Joining of arguments is moved to `_load_parts`, which is called when a normalized path is needed.
AlexWaygood
reviewed
Jun 7, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Looks really nice (I love the approach) — just one question:
Sorry, something went wrong.
barneygale
commented
Jun 7, 2023
AlexWaygood
approved these changes
Jun 7, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Great work!
Sorry, something went wrong.
eryksun
reviewed
Jun 7, 2023
Contributor
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
Contributor
|
Sorry, @barneygale, I could not cleanly backport this to |
Sorry, something went wrong.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jun 7, 2023
…thonGH-104999) Joining of arguments is moved to `_load_parts`, which is called when a normalized path is needed. (cherry picked from commit ffeaec7)
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jun 7, 2023
…ts. (pythonGH-104999) Joining of arguments is moved to `_load_parts`, which is called when a normalized path is needed.. (cherry picked from commit ffeaec7) Co-authored-by: Barney Gale <barney.gale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Joining of arguments is moved to
_load_parts, which is called when a normalized path is needed.