{{ message }}
GH-104584: Optimizer API#105100
Merged
markshannon merged 18 commits intoJun 2, 2023
Merged
Conversation
Member
Sorry, something went wrong.
markshannon
requested review from
a team,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
May 30, 2023 16:17
markshannon
requested review from
brandtbucher
and removed request for
a team,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
May 30, 2023 16:26
29 hidden items
Load more…
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
Looks good in general. Probably needs a test with buildbots though.
Sorry, something went wrong.
Eclips4
reviewed
May 30, 2023
brandtbucher
reviewed
Jun 1, 2023
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Cool! Just a small flurry of questions, comments, and nits:
Sorry, something went wrong.
11 hidden conversations
Load more…
zooba
reviewed
Jun 1, 2023
carljm
reviewed
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Only supports back edges. Adding hooks for resumption points (the
RESUMEinstruction) is for a later PR.Performance for an earlier version was mostly noise.
In theory we could turn off the check by using adaptive bytecode, but as we will want an always-on optimizer for tier 2, there seems little advantage to doing so.