◐ Shell
reader mode source ↗
Skip to content

gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1.#105129

Closed
ned-deily wants to merge 3 commits into
python:mainfrom
ned-deily:gh-103142-multissltests
Closed

gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1.#105129
ned-deily wants to merge 3 commits into
python:mainfrom
ned-deily:gh-103142-multissltests

Conversation

@ned-deily

@ned-deily ned-deily commented May 31, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@ned-deily ned-deily added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 31, 2023
@ned-deily ned-deily changed the title Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. May 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 31, 2023
Closed
@ned-deily ned-deily changed the title gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. May 31, 2023
@ned-deily ned-deily requested review from ambv and gpshead May 31, 2023 19:48
@gpshead gpshead mentioned this pull request May 31, 2023
Merged
@gpshead

gpshead commented May 31, 2023

Copy link
Copy Markdown
Member

There are PCbuild/ and .azure-pipelines/ references that also need updating (see my draft #105174 which I was just basing off of what I blindly did for the previous update in #101727). But lets go forward with your PR here just adding those bits. I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

@gpshead

gpshead commented May 31, 2023

Copy link
Copy Markdown
Member

some windows versions may need to wait on someone uploading an openssl-bin-1.1.1u artifact somewhere? based on #101727 comments @zooba did that last time.

@gpshead gpshead requested a review from zooba May 31, 2023 22:22
@zooba

zooba commented May 31, 2023

Copy link
Copy Markdown
Member

I've posted the binaries for Windows. They are codesigned, so have to be done by someone with release team access.

I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

I thought there was an open issue/PR to replace this file? As we should have access to OpenSSL's copies of this data. Guess it isn't merged yet...

@gpshead

gpshead commented Jun 1, 2023

Copy link
Copy Markdown
Member

I updated my PR #105174 to have the additional bits that this touched plus a tweak to the _ssl_data .h file regeneration. If CI and buildbots are happy with it, I'll merge mine and generate the backport PRs.

@gpshead gpshead marked this pull request as draft June 1, 2023 03:32
@ned-deily

ned-deily commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

Closed in favor of #105174

@ned-deily ned-deily closed this Jun 1, 2023
@gpshead

gpshead commented Jun 1, 2023

Copy link
Copy Markdown
Member

woo, thanks Ned! (we were both considering this, when I created my PR I hadn't yet looked to see if someone else had taken this on. No worries from my end about the duplicate work collision, it's good to have eyeballs on the issue).

@ned-deily ned-deily deleted the gh-103142-multissltests branch June 6, 2023 18:49
@ambv ambv removed needs backport to 3.8 needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@gpshead gpshead gpshead is a code owner

@ambv ambv Awaiting requested review from ambv

@zooba zooba Awaiting requested review from zooba

@picnixz picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Assignees

No one assigned

Labels

Projects

Release and Deferred blockers 🚫
Status: Done +1 more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ned-deily @gpshead @zooba @ambv @bedevere-bot