◐ Shell
reader mode source ↗
Skip to content

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc#105190

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:PyErr_Print-doc
Jun 2, 2023
Merged

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc#105190
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:PyErr_Print-doc

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 1, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

PyErr_PrintEx now populates also sys.last_exc, and the old variables are still populated by deprecated.

📚 Documentation preview 📚: https://cpython-previews--105190.org.readthedocs.build/

@iritkatriel iritkatriel added docs Documentation in the Doc dir needs backport to 3.12 only security fixes labels Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Closed
@iritkatriel iritkatriel changed the title gh-102778: update documentation of PyErr_PrintEx regarding sys.last_exc Jun 1, 2023
@iritkatriel iritkatriel requested a review from terryjreedy June 1, 2023 18:23
terryjreedy
terryjreedy requested changes Jun 1, 2023
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Approved with change.

@bedevere-bot

bedevere-bot commented Jun 1, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatriel @terryjreedy
Apply suggestions from code review …
00a6936 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@iritkatriel

iritkatriel commented Jun 2, 2023

Copy link
Copy Markdown
Member Author

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from terryjreedy June 2, 2023 10:21
@iritkatriel iritkatriel merged commit 0dafc78 into python:main Jun 2, 2023
@miss-islington

miss-islington commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2023
@iritkatriel @miss-islington
pythongh-102778: update documentation of PyErr_PrintEx and traceback.… …
de2b136 
…print_last() regarding sys.last_exc (pythonGH-105190)

(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

GH-105246 is a backport of this pull request to the 3.12 branch.

iritkatriel added a commit that referenced this pull request Jun 2, 2023
@miss-islington @iritkatriel
[3.12] gh-102778: update documentation of PyErr_PrintEx and traceback… …
00fe618 
….print_last() regarding sys.last_exc (GH-105190) (#105246)

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc (GH-105190)
(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
@iritkatriel iritkatriel deleted the PyErr_Print-doc branch July 25, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel @bedevere-bot @miss-islington @terryjreedy