gh-105481: add pseudo-instructions to the cases DSL#105506
Conversation
|
I'll look into adding unit tests for the generator. |
Sorry, something went wrong.
Actually the test are not running anymore, right? (I mean the ones in Tools/cases_generator/test_generator.py). |
Sorry, something went wrong.
Sadly those must be run manually (since they use pytest) and I have neglected to do so, so they are broken. I've filed gh-105540 for that. |
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
A great start. I suppose before you land this you are going to make it so that the new metadata is actually used? Or will that be a separate PR?
Sorry, something went wrong.
|
I guess still waiting for the pseudo PR? |
Sorry, something went wrong.
|
I’m not sure where we would use the metadata for pseudo instructions. It probably makes sense to add assertions in the places where we map them to real instructions, that the metadata is the same. I’ll have a look tomorrow (or so). |
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
Sorry, I was confusing this PR with gh-105482. That one uses the metadata. This one LGTM!
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot wasm32-wasi 3.x has failed when building commit 58f5227. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1046/builds/2267 Failed tests:
Summary of the results of the build (if available): == Tests result: FAILURE == 317 tests OK. 10 slowest tests:
1 test failed: 129 tests skipped: Total duration: 5 min 20 sec Click to see traceback logsTraceback (most recent call last):
File "/Lib/test/string_tests.py", line 335, in test_find_periodic_pattern
self.checkequal(reference_find(p, text),
File "/Lib/test/test_userstring.py", line 24, in checkequal
self.assertEqual(
AssertionError: -1 != 0
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot ARM Raspbian 3.x has failed when building commit 58f5227. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/424/builds/4187 Summary of the results of the build (if available): == Tests result: ENV CHANGED == 427 tests OK. 10 slowest tests:
1 test altered the execution environment: 19 tests skipped: Total duration: 38 min 31 sec Click to see traceback logsremote: Enumerating objects: 25, done.
remote: Counting objects: 4% (1/25)
remote: Counting objects: 8% (2/25)
remote: Counting objects: 12% (3/25)
remote: Counting objects: 16% (4/25)
remote: Counting objects: 20% (5/25)
remote: Counting objects: 24% (6/25)
remote: Counting objects: 28% (7/25)
remote: Counting objects: 32% (8/25)
remote: Counting objects: 36% (9/25)
remote: Counting objects: 40% (10/25)
remote: Counting objects: 44% (11/25)
remote: Counting objects: 48% (12/25)
remote: Counting objects: 52% (13/25)
remote: Counting objects: 56% (14/25)
remote: Counting objects: 60% (15/25)
remote: Counting objects: 64% (16/25)
remote: Counting objects: 68% (17/25)
remote: Counting objects: 72% (18/25)
remote: Counting objects: 76% (19/25)
remote: Counting objects: 80% (20/25)
remote: Counting objects: 84% (21/25)
remote: Counting objects: 88% (22/25)
remote: Counting objects: 92% (23/25)
remote: Counting objects: 96% (24/25)
remote: Counting objects: 100% (25/25)
remote: Counting objects: 100% (25/25), done.
remote: Compressing objects: 12% (1/8)
remote: Compressing objects: 25% (2/8)
remote: Compressing objects: 37% (3/8)
remote: Compressing objects: 50% (4/8)
remote: Compressing objects: 62% (5/8)
remote: Compressing objects: 75% (6/8)
remote: Compressing objects: 87% (7/8)
remote: Compressing objects: 100% (8/8)
remote: Compressing objects: 100% (8/8), done.
remote: Total 13 (delta 12), reused 6 (delta 5), pack-reused 0
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '58f5227d7cdff803609a0bda6882997b3a5ec4bf'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 58f5227d7c gh-105481: add pseudo-instructions to the bytecodes DSL (#105506)
Switched to and reset branch 'main'
In file included from ./Include/Python.h:44,
from ./Python/sysmodule.c:17:
./Python/sysmodule.c: In function ‘_PySys_UpdateConfig’:
./Include/object.h:692:9: warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized]
692 | _Py_Dealloc(op);
| ^~~~~~~~~~~~~~~
./Python/sysmodule.c:3378:22: note: ‘value’ was declared here
3378 | PyObject *name, *value;
| ^~~~~
./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:62:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
62 | (unsigned long long)data_ptr,
| ^
make: *** [Makefile:2003: buildbottest] Error 3 |
Sorry, something went wrong.
edited by bedevere-bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.