◐ Shell
reader mode source ↗
Skip to content

gh-105687: Remove deprecated objects from re module#105688

Merged
vstinner merged 3 commits into
python:mainfrom
sobolevn:issue-105687
Jun 14, 2023
Merged

gh-105687: Remove deprecated objects from re module#105688
vstinner merged 3 commits into
python:mainfrom
sobolevn:issue-105687

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 12, 2023

Copy link
Copy Markdown
Member

@sobolevn sobolevn requested a review from vstinner June 12, 2023 12:24
@vstinner

Copy link
Copy Markdown
Member

I already proposed to remove these APIs directly, without deprecation period. But @serhiy-storchaka wanted to collect feedback of users with a deprecation period. So far, I am not aware of any feedback.

This feature can be reimplemented outside Python stdlib if needed, no?

@vstinner

Copy link
Copy Markdown
Member

cc @hugovk

@serhiy-storchaka

Copy link
Copy Markdown
Member

I already proposed to remove these APIs directly, without deprecation period. But @serhiy-storchaka wanted to collect feedback of users with a deprecation period.

Actually, I initially removed it without deprecation, because it clearly looked to me as unfinished in process of initial implementation and later broken feature.

My best guess is that it was purposed to make all quntifiers possessive. But initial implementation of atomic groups and possessive quantifiers was broken. Now we have working implementation, and can enable that feature. To disable backtracking it would need also wrap every alternation into atomic group. We can do this now if it was initial purpose, but I have no idea why somebody would need such feature.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Thanks for the enhanced doc.

@vstinner vstinner merged commit 67f69db into python:main Jun 14, 2023
@vstinner

Copy link
Copy Markdown
Member

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants