◐ Shell
reader mode source ↗
Skip to content

gh-105751: Cleanup test_ctypes imports#105803

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:test_ctypes_cleanup
Jun 14, 2023
Merged

gh-105751: Cleanup test_ctypes imports#105803
vstinner merged 2 commits into
python:mainfrom
vstinner:test_ctypes_cleanup

Conversation

@vstinner

@vstinner vstinner commented Jun 14, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • Move imports at top level and sort imports.
  • Replace c_buffer() with create_string_buffer(): c_buffer is a deprecated alias.
  • PEP 8: Add empty lines for readability between imports and classes.

@vstinner
pythongh-105751: Cleanup test_ctypes imports …
a2de459 
* Move imports at top level and sort imports.
* Replace c_buffer() with create_string_buffer(): c_buffer is a
  deprecated alias.
* PEP 8: Add empty lines for readability between imports and classes.
@vstinner vstinner requested a review from rhettinger as a code owner June 14, 2023 22:40
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 14, 2023
@vstinner vstinner added skip news and removed tests Tests in the Lib/test dir labels Jun 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 14, 2023
Closed
@vstinner vstinner enabled auto-merge (squash) June 14, 2023 22:48
@vstinner vstinner disabled auto-merge June 14, 2023 22:54
@vstinner vstinner enabled auto-merge (squash) June 14, 2023 22:54
@vstinner vstinner merged commit 698a0da into python:main Jun 14, 2023
@bedevere-bot bedevere-bot removed the label Jun 14, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jun 15, 2023
@carljm
Merge branch 'main' into modulelocals …
166aca9 
* main: (57 commits)
  pythongh-105831: Fix NEWS blurb from pythongh-105828 (python#105833)
  pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)
  pythongh-105751, test_ctypes: Remove disabled tests (python#105826)
  pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)
  pythongh-105751: Remove platform usage in test_ctypes (python#105819)
  pythongh-105751: Reenable disable test_ctypes tests (python#105818)
  pythongh-105751: Remove dead code in test_ctypes (python#105817)
  More reorganisation of the typing docs (python#105787)
  Improve docs for `typing.dataclass_transform` (python#105792)
  pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)
  pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)
  pythongh-105751: Cleanup test_ctypes imports (python#105803)
  pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)
  pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)
  pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)
  pythongh-104909: Implement conditional stack effects for macros (python#105748)
  pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)
  pythongh-105481: Fix types and a bug for pseudos (python#105788)
  Update DSL docs for cases generator (python#105753)
  pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132)
  ...
@vstinner vstinner deleted the test_ctypes_cleanup branch June 27, 2023 23:16
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 31, 2023
@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 698a0da7d440856a90b45964e9082b5a55387b80 3.12

@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 698a0da7d440856a90b45964e9082b5a55387b80 3.11

@ambv

ambv commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

oh-no

@ambv

ambv commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

OK, giving up on backporting everything. It's a bummer it wasn't done though.

@ambv ambv removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @ambv @bedevere-bot