◐ Shell
reader mode source ↗
Skip to content

gh-104799: PEP 695 backward compatibility for ast.unparse#105846

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:unparse
Jun 16, 2023
Merged

gh-104799: PEP 695 backward compatibility for ast.unparse#105846
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:unparse

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jun 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra marked this pull request as ready for review June 16, 2023 01:12
@bedevere-bot bedevere-bot mentioned this pull request Jun 16, 2023
Closed
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Jun 16, 2023
@AlexWaygood AlexWaygood self-requested a review June 16, 2023 07:57
AlexWaygood
AlexWaygood approved these changes Jun 16, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@JelleZijlstra JelleZijlstra merged commit 957a974 into python:main Jun 16, 2023
@miss-islington

miss-islington commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 957a974d4fc1575787e4a29a399a47520d6df6d3 3.12

@JelleZijlstra JelleZijlstra deleted the unparse branch June 16, 2023 16:31
@miss-islington

miss-islington commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 16, 2023

Copy link
Copy Markdown

GH-105862 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 16, 2023
JelleZijlstra added a commit that referenced this pull request Jun 16, 2023
@miss-islington @JelleZijlstra
[3.12] gh-104799: PEP 695 backward compatibility for ast.unparse (GH-… …
5ca707d 
…105846) (#105862)

(cherry picked from commit 957a974)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals …
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@JelleZijlstra @gvanrossum
pythongh-104799: PEP 695 backward compatibility for ast.unparse (pyth… …
bc91df7 
…on#105846)
@JelleZijlstra JelleZijlstra restored the unparse branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra @miss-islington @bedevere-bot @AlexWaygood