gh-105858: Improve AST node constructors#105880

JelleZijlstra

Demonstration:

>>> ast.FunctionDef.__annotations__
{'name': <class 'str'>, 'args': <class 'ast.arguments'>, 'body': list[ast.stmt], 'decorator_list': list[ast.expr], 'returns': ast.expr | None, 'type_comment': str | None, 'type_params': list[ast.type_param]}
>>> ast.FunctionDef()
<stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'name'. This will become an error in Python 3.15.
<stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'args'. This will become an error in Python 3.15.
<ast.FunctionDef object at 0x101959460>
>>> node = ast.FunctionDef(name="foo", args=ast.arguments())
>>> node.decorator_list
[]
>>> ast.FunctionDef(whatever="you want", name="x", args=ast.arguments())
<stdin>:1: DeprecationWarning: FunctionDef.__init__ got an unexpected keyword argument 'whatever'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.
<ast.FunctionDef object at 0x1019581f0>

Issue: Improve the constructors of AST nodes #105858

Demonstration: >>> ast.FunctionDef.__annotations__ {'name': <class 'str'>, 'args': <class 'ast.arguments'>, 'body': list[ast.stmt], 'decorator_list': list[ast.expr], 'returns': ast.expr | None, 'type_comment': str | None, 'type_params': list[ast.type_param]} >>> ast.FunctionDef() <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'name'. This will become an error in Python 3.15. <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'args'. This will become an error in Python 3.15. <ast.FunctionDef object at 0x101959460> >>> node = ast.FunctionDef(name="foo", args=ast.arguments()) >>> node.decorator_list [] >>> ast.FunctionDef(whatever="you want", name="x", args=ast.arguments()) <stdin>:1: DeprecationWarning: FunctionDef.__init__ got an unexpected keyword argument 'whatever'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15. <ast.FunctionDef object at 0x1019581f0> Known problems: - Subclasses of AST nodes don't work properly, because we don't look up __annotations__ on the right class. - Unpickling throws DeprecationWarnings, probably because of how we construct the unpickled object. Need to think more about how to handle those cases.

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a2442b6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

carljm

If you are satisfied with the Discourse thread outcome, the code here LGTM! Thanks for this improvement.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g., NoneType) are already exposed as internal APIs.

Demonstration: >>> ast.FunctionDef.__annotations__ {'name': <class 'str'>, 'args': <class 'ast.arguments'>, 'body': list[ast.stmt], 'decorator_list': list[ast.expr], 'returns': ast.expr | None, 'type_comment': str | None, 'type_params': list[ast.type_param]} >>> ast.FunctionDef() <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'name'. This will become an error in Python 3.15. <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'args'. This will become an error in Python 3.15. <ast.FunctionDef object at 0x101959460> >>> node = ast.FunctionDef(name="foo", args=ast.arguments()) >>> node.decorator_list [] >>> ast.FunctionDef(whatever="you want", name="x", args=ast.arguments()) <stdin>:1: DeprecationWarning: FunctionDef.__init__ got an unexpected keyword argument 'whatever'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15. <ast.FunctionDef object at 0x1019581f0>

) We now use these in the AST parsing code after gh-105880. A few comparable types (e.g., NoneType) are already exposed as internal APIs.

Demonstration: >>> ast.FunctionDef.__annotations__ {'name': <class 'str'>, 'args': <class 'ast.arguments'>, 'body': list[ast.stmt], 'decorator_list': list[ast.expr], 'returns': ast.expr | None, 'type_comment': str | None, 'type_params': list[ast.type_param]} >>> ast.FunctionDef() <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'name'. This will become an error in Python 3.15. <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'args'. This will become an error in Python 3.15. <ast.FunctionDef object at 0x101959460> >>> node = ast.FunctionDef(name="foo", args=ast.arguments()) >>> node.decorator_list [] >>> ast.FunctionDef(whatever="you want", name="x", args=ast.arguments()) <stdin>:1: DeprecationWarning: FunctionDef.__init__ got an unexpected keyword argument 'whatever'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15. <ast.FunctionDef object at 0x1019581f0>

…ythonGH-116025) We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g., NoneType) are already exposed as internal APIs.

Demonstration: >>> ast.FunctionDef.__annotations__ {'name': <class 'str'>, 'args': <class 'ast.arguments'>, 'body': list[ast.stmt], 'decorator_list': list[ast.expr], 'returns': ast.expr | None, 'type_comment': str | None, 'type_params': list[ast.type_param]} >>> ast.FunctionDef() <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'name'. This will become an error in Python 3.15. <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'args'. This will become an error in Python 3.15. <ast.FunctionDef object at 0x101959460> >>> node = ast.FunctionDef(name="foo", args=ast.arguments()) >>> node.decorator_list [] >>> ast.FunctionDef(whatever="you want", name="x", args=ast.arguments()) <stdin>:1: DeprecationWarning: FunctionDef.__init__ got an unexpected keyword argument 'whatever'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15. <ast.FunctionDef object at 0x1019581f0>

…ythonGH-116025) We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g., NoneType) are already exposed as internal APIs.

Demonstration: >>> ast.FunctionDef.__annotations__ {'name': <class 'str'>, 'args': <class 'ast.arguments'>, 'body': list[ast.stmt], 'decorator_list': list[ast.expr], 'returns': ast.expr | None, 'type_comment': str | None, 'type_params': list[ast.type_param]} >>> ast.FunctionDef() <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'name'. This will become an error in Python 3.15. <stdin>:1: DeprecationWarning: FunctionDef.__init__ missing 1 required positional argument: 'args'. This will become an error in Python 3.15. <ast.FunctionDef object at 0x101959460> >>> node = ast.FunctionDef(name="foo", args=ast.arguments()) >>> node.decorator_list [] >>> ast.FunctionDef(whatever="you want", name="x", args=ast.arguments()) <stdin>:1: DeprecationWarning: FunctionDef.__init__ got an unexpected keyword argument 'whatever'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15. <ast.FunctionDef object at 0x1019581f0>

…ythonGH-116025) We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g., NoneType) are already exposed as internal APIs.

Python 3.13 added the warning which will become an error in Python 3.15 (see python/cpython#105880)

bedevere-bot mentioned this pull request Jun 17, 2023

Improve the constructors of AST nodes #105858

Closed

JelleZijlstra added 7 commits June 21, 2023 18:42

Merge remote-tracking branch 'upstream/main' into astcons

d417cf3

Fix subclasses

c74740a

Fix most deprecationwarnings in test_ast

05d5569

Merge remote-tracking branch 'upstream/main' into astcons

f4b14ac

Fix renamed function

0efcdf3

Fix pickling; fix a refleak

f941696

Fix other refleak

4c42748

JelleZijlstra marked this pull request as ready for review October 24, 2023 19:55

JelleZijlstra requested a review from isidentical as a code owner October 24, 2023 19:55

bedevere-app Bot added the awaiting core review label Oct 24, 2023

JelleZijlstra added 2 commits October 24, 2023 12:55

Merge branch 'main' into astcons

1a9b872

Merge branch 'main' into astcons

db16cc7

JelleZijlstra commented Feb 18, 2024

View reviewed changes

JelleZijlstra added 2 commits February 18, 2024 06:39

Update Parser/asdl_c.py

6bf677b

fix merge

a2442b6

JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 18, 2024

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 18, 2024

JelleZijlstra requested a review from carljm February 19, 2024 05:08

carljm reviewed Feb 21, 2024

View reviewed changes

Expand NEWS

5a1d37a

carljm approved these changes Feb 21, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 21, 2024

JelleZijlstra added 2 commits February 25, 2024 14:40

Merge remote-tracking branch 'upstream/main' into astcons

c4627a1

docs

1f85438

AlexWaygood reviewed Feb 25, 2024

View reviewed changes

Apply suggestions from code review …

ff0cc67

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

JelleZijlstra mentioned this pull request Feb 28, 2024

gh-105858: Expose some union-related objects as internal APIs #116025

Merged

This comment was marked as duplicate.

Sign in to view

encukou pushed a commit that referenced this pull request Feb 28, 2024

gh-105858: Expose some union-related objects as internal APIs (GH-116025 …

d53560d

) We now use these in the AST parsing code after gh-105880. A few comparable types (e.g., NoneType) are already exposed as internal APIs.

serhiy-storchaka reviewed Mar 6, 2024

View reviewed changes

JelleZijlstra mentioned this pull request May 19, 2024

bpo-39981: Introduce default values for AST node classes #21417

Closed

JelleZijlstra restored the astcons branch September 10, 2024 23:37

cedk added a commit to cedk/genshi that referenced this pull request May 11, 2025

Fix deprecation warning when creating AST node without required fields …

bfcf119

Python 3.13 added the warning which will become an error in Python 3.15 (see python/cpython#105880)

cedk mentioned this pull request May 11, 2025

Fix deprecation warning when creating AST node without required fields edgewall/genshi#93

Open

cedk added a commit to cedk/genshi that referenced this pull request May 18, 2026

Fix deprecation warning when creating AST node without required fields …

0bbe1df

Python 3.13 added the warning which will become an error in Python 3.15 (see python/cpython#105880)

cedk added a commit to cedk/genshi that referenced this pull request May 18, 2026

Fix deprecation warning when creating AST node without required fields …

0bcd1ee

Python 3.13 added the warning which will become an error in Python 3.15 (see python/cpython#105880)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-105858: Improve AST node constructors#105880

gh-105858: Improve AST node constructors#105880
JelleZijlstra merged 18 commits into
python:mainfrom
JelleZijlstra:astcons

JelleZijlstra commented Jun 17, 2023 •

edited

Loading

Uh oh!

bedevere-bot commented Feb 18, 2024

Uh oh!

carljm left a comment

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JelleZijlstra commented Jun 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Feb 18, 2024

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JelleZijlstra commented Jun 17, 2023 •

edited

Loading