◐ Shell
reader mode source ↗
Skip to content

gh-105879: Add support for keyword arguments to eval and exec#105885

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
rtpg:exec-kwargs
May 2, 2024
Merged

gh-105879: Add support for keyword arguments to eval and exec#105885
JelleZijlstra merged 8 commits into
python:mainfrom
rtpg:exec-kwargs

Conversation

@rtpg

@rtpg rtpg commented Jun 17, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot

bedevere-bot commented Jun 17, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot mentioned this pull request Jun 17, 2023
Closed
@ghost

ghost commented Jun 17, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

hauntsaninja
hauntsaninja approved these changes Jun 24, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for suggesting and adding this feature! I've definitely confused the ordering of these before :-) This looks good to me (although I think I still have a vague preference for keeping the source argument positional-only)

@iritkatriel

iritkatriel commented Jun 25, 2023

Copy link
Copy Markdown
Member

Does this need a doc change?

@rtpg

rtpg commented Jul 4, 2023

Copy link
Copy Markdown
Contributor Author

@iritkatriel i believe that the docstring changes (derived from the arg clinic changes) are sufficient, as I did not see anything being explicit about positional-only-ness beyond that

@JelleZijlstra JelleZijlstra self-assigned this May 1, 2024
@rtpg rtpg requested a review from ericsnowcurrently as a code owner May 1, 2024 16:21
@JelleZijlstra

JelleZijlstra commented May 1, 2024

Copy link
Copy Markdown
Member

I fixed the (trivial) merge conflict, undid an unnecessary formatting change, and added a documentation note as @iritkatriel suggested. I'll merge the PR in a bit so we can get this change into 3.13.

@JelleZijlstra

JelleZijlstra commented May 2, 2024

Copy link
Copy Markdown
Member

Thinking about it again I agree with @hauntsaninja's suggestion above that we should leave the first argument positional-only. I'll make that change.

@JelleZijlstra JelleZijlstra merged commit 2770d5c into python:main May 2, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@rtpg @JelleZijlstra @SonicField
pythongh-105879: Add support for keyword arguments to eval and exec (p… …
b2ff973 
…ython#105885)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@vadmium vadmium mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rtpg @bedevere-bot @iritkatriel @JelleZijlstra @hauntsaninja