gh-106307: Add PyMapping_GetOptionalItem()#106308
Conversation
Sorry, something went wrong.
serhiy-storchaka
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
July 1, 2023 12:31
Replacement of PyObject_GetItem() which doesn't raise KeyError. int _PyMapping_LookupItem(PyObject *obj, PyObject *key, PyObject **result) Return 1 and set *result != NULL if a key is found. Return 0 and set *result == NULL if a key is not found; a KeyError is silenced. Return -1 and set *result == NULL if an error other than KeyError is raised.
serhiy-storchaka
force-pushed
the
_PyMapping_LookupItem
branch
from
cfc5851 to
078ea48
Compare
July 1, 2023 20:46
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
The bytecodes.c cleanups alone (i.e. the existing cases where we cared enough about perf to special-case the exact-dict fast path) clearly show the value of this API! Now all call sites can get the same perf benefit, with much less verbosity.
Sorry, something went wrong.
Co-authored-by: Carl Meyer <carl@oddbird.net> Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Carl Meyer <carl@oddbird.net>
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Reviewers
6 participants
Replacement of PyObject_GetItem() which doesn't raise KeyError.
Return 1 and set *result != NULL if a key is found.
Return 0 and set *result == NULL if a key is not found; a KeyError is silenced.
Return -1 and set *result == NULL if an error other than KeyError is raised.