{{ message }}
gh-104584: Handle EXTENDED_ARG in superblock creation#106489
Merged
gvanrossum merged 2 commits intoJul 6, 2023
Merged
Conversation
Member
Author
|
Tests are failing. I'll regroup and see if my EXTENDED_ARG handling is at fault or if it was pre-existing, and then proceed from there. For now, this is another Draft PR, and I'll isolate my test cleanups in a new PR. UPDATE: Fixed by gh-106492, rebased, undrafted. |
Sorry, something went wrong.
Member
Author
|
I get the same failure with just Fix and clean up uops and executor API. That makes me think the root problem is pre-existing (since that commit has no C code). I'll see if the address sanitizer will help me debug this. UPDATE: Yeah, the UOpOptimizer type was missing a tp_dealloc handler. Nasty. Fixing that in gh-106492. Once that's merged I'll rebase and undraft this. |
Sorry, something went wrong.
ba006c1 to
f11ebff
Compare
July 6, 2023 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Also fixed and cleaned up
test_capi.test_misc.TestUops, and added a new test proving thatEXTENDED_ARGworks.