gh-104469 Convert_testcapi/vectorcall.c to use AC#106557
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
Sorry, something went wrong.
sobolevn
left a comment
There was a problem hiding this comment.
I don't think that we need to convert test_ prefixed functions. They are executed as tests directly.
Sorry, something went wrong.
Well, I am okay with it. We already did. |
Sorry, something went wrong.
corona10
left a comment
There was a problem hiding this comment.
First thing, method names are wrong.
Please change method names and then executing the make clinic
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
|
@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases. |
Sorry, something went wrong.
According to CI, it looks not, did you rebuild the code? |
Sorry, something went wrong.
No, I didn't. I just ran |
Sorry, something went wrong.
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
corona10
left a comment
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.