◐ Shell
reader mode source ↗
Skip to content

gh-105481: expose opcode metadata via the _opcode module#106688

Merged
iritkatriel merged 10 commits into
python:mainfrom
iritkatriel:expose_metadata
Jul 14, 2023
Merged

gh-105481: expose opcode metadata via the _opcode module#106688
iritkatriel merged 10 commits into
python:mainfrom
iritkatriel:expose_metadata

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@iritkatriel iritkatriel requested a review from gvanrossum July 12, 2023 18:47
@bedevere-bot bedevere-bot mentioned this pull request Jul 12, 2023
Closed
@iritkatriel iritkatriel requested a review from markshannon as a code owner July 12, 2023 20:35
@iritkatriel iritkatriel marked this pull request as draft July 12, 2023 20:40
@iritkatriel

iritkatriel commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

There's a problem here with the definition of the metadata table. I'll try to sort it out tomorrow.

@iritkatriel iritkatriel marked this pull request as ready for review July 14, 2023 14:39
gvanrossum
gvanrossum approved these changes Jul 14, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Something worries me about the amount of repetition for each flag. But the alternative (exposing the flags as an int, and the constants) seems worse. So go for it!

@iritkatriel

iritkatriel commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

Yes, I didn't want to expose the bitmap implementation.

@iritkatriel iritkatriel merged commit 6a70edf into python:main Jul 14, 2023
@iritkatriel iritkatriel deleted the expose_metadata branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel @gvanrossum @bedevere-bot