gh-86493: Modernize modules initialization code#106858
Conversation
Sorry, something went wrong.
Use PyModule_Add() or PyModule_AddObjectRef() instead of soft deprecated PyModule_AddObject().
serhiy-storchaka
requested review from
abalkin,
corona10,
pganssle,
rhettinger and
tiran
as code owners
July 18, 2023 10:06
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but a few compiler warnings should be fixed first: see GHA job results, especially the Ubuntu job which logged many warnings.
Sorry, something went wrong.
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
lgtm too
Sorry, something went wrong.
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I didn't check individual refcount, I rely on Refleaks buildbots for that and other reviewers 😁 Overall the change LGTM and makes the code shorter and more regular. The old code was really hard to understand with INCREF/DECREF dance.
Sorry, something went wrong.
|
That's a big change, thanks. |
Sorry, something went wrong.
Use PyModule_Add() or PyModule_AddObjectRef() instead of soft deprecated PyModule_AddObject().
Use PyModule_Add() or PyModule_AddObjectRef() instead of soft deprecated PyModule_AddObject().
PyModule_AddObject() is only left in two modules:
_testcapiand_testbuffer. But that code ignores any failures for now. They need more significant rewriting.📚 Documentation preview 📚: https://cpython-previews--106858.org.readthedocs.build/