◐ Shell
reader mode source ↗
Skip to content

gh-106976: alphabetise bullets by module name task2-3#107005

Merged
hugovk merged 8 commits into
python:mainfrom
littlebutt:gh-106976-other-tasks
Jul 23, 2023
Merged

gh-106976: alphabetise bullets by module name task2-3#107005
hugovk merged 8 commits into
python:mainfrom
littlebutt:gh-106976-other-tasks

Conversation

@littlebutt

@littlebutt littlebutt commented Jul 22, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
Closed
4 tasks
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 22, 2023
@hugovk hugovk added the needs backport to 3.12 only security fixes label Jul 23, 2023
hugovk
hugovk requested changes Jul 23, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, one small update needed.

@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

littlebutt and others added 2 commits July 23, 2023 08:18
@littlebutt @hugovk
Update Doc/whatsnew/3.12.rst …
2b7804f 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@littlebutt
Merge branch 'main' into pythongh-106976-other-tasks
8c78c6d
@littlebutt

littlebutt commented Jul 23, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from hugovk July 23, 2023 08:25
hugovk
hugovk approved these changes Jul 23, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks again!

@hugovk hugovk enabled auto-merge (squash) July 23, 2023 09:37
@hugovk hugovk merged commit 102a773 into python:main Jul 23, 2023
@miss-islington

miss-islington commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @littlebutt for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

GH-107106 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@littlebutt @hugovk @miss-islington
pythongh-106976: alphabetise bullets by module name task2-3 (pythonGH… …
11bb6d0 
…-107005)

(cherry picked from commit 102a773)

Co-authored-by: littlebutt's workshop <luogan199686@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 23, 2023
hugovk added a commit that referenced this pull request Jul 23, 2023
@miss-islington @littlebutt @hugovk
[3.12] gh-106976: alphabetise bullets by module name task2-3 (GH-107005… …
a73d5c5 
…) (#107106)

Co-authored-by: littlebutt's workshop <luogan199686@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@littlebutt @hugovk @jtcave
pythongh-106976: alphabetise bullets by module name task2-3 (python#1… …
05e4f57 
…07005)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@littlebutt @hugovk @mementum
pythongh-106976: alphabetise bullets by module name task2-3 (python#1… …
4853769 
…07005)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@AA-Turner AA-Turner mentioned this pull request Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@littlebutt @bedevere-bot @miss-islington @hugovk