◐ Shell
reader mode source ↗
Skip to content

gh-107017: Rework the Fibonacci example#107132

Closed
TommyUnreal wants to merge 17 commits into
python:mainfrom
TommyUnreal:107017_tutorial_introduction_assumtions_removal_fibonacci
Closed

gh-107017: Rework the Fibonacci example#107132
TommyUnreal wants to merge 17 commits into
python:mainfrom
TommyUnreal:107017_tutorial_introduction_assumtions_removal_fibonacci

Conversation

@TommyUnreal

@TommyUnreal TommyUnreal commented Jul 23, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Rework the example to be simple to follow and also the concepts needed for that are now explained one by one with their own shorter examples.

Needs proofread. Please comment with your ideas for improvement.

📚 Documentation preview 📚: https://cpython-previews--107132.org.readthedocs.build/

@TommyUnreal
Draft. Rework ´the Fibonacci example. …
2383c73 
Rework the example to be simple to follow and also the concepts needed
for that are now explained one by one with their own shorter examples.
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jul 23, 2023
@TommyUnreal TommyUnreal marked this pull request as draft July 23, 2023 14:15
@TommyUnreal TommyUnreal marked this pull request as ready for review July 23, 2023 21:53
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 29, 2023
@TommyUnreal
Fix review hints. Explain condition better. …
e87530d 
Fix parts where a paragraph ended both with full-stop and colon.
Added new paragraph, where example of simple loop is explained in
detail. Plus warning about indefinite loops.
@TommyUnreal
Fix inline literals.
10107c1
@TommyUnreal TommyUnreal requested review from evildmp and hugovk July 29, 2023 07:37
TommyUnreal and others added 3 commits July 29, 2023 09:52
@TommyUnreal @CaedenPH
Update Doc/tutorial/introduction.rst …
cdafb1f 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@TommyUnreal @CaedenPH
Update Doc/tutorial/introduction.rst …
3c9bec8 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@TommyUnreal @CaedenPH
Update Doc/tutorial/introduction.rst …
6ad0175 
More precise and clearer wording.

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
CaedenPH
CaedenPH approved these changes Jul 29, 2023
View reviewed changes

@CaedenPH CaedenPH left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Other than these grammatical mistakes, looks like a good change to me

TommyUnreal and others added 2 commits July 29, 2023 12:10
@TommyUnreal @CaedenPH
Corrected grammar errors. …
3c0171e 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@TommyUnreal
Better wording in example comment. …
fbb36a0 
lower the value -> decrease the value
SylvainDe
SylvainDe reviewed Aug 22, 2023
View reviewed changes

@SylvainDe SylvainDe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Very nice touch! Here are 2 cosmetic details

hugovk
hugovk reviewed Aug 23, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

A suggestion and some little wording things, otherwise looks good!

@hauntsaninja

hauntsaninja commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Thanks for working on this! As compared to the version on the left hand side, I found presenting all the concepts up front in detailed sections a little intimidating. I preferred seeing the four lines we're building towards first, and then an explanation of what's going on.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.11 only security fixes labels May 9, 2024
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@hugovk hugovk changed the title gh-107017: Rework the Fibonacci example. Apr 10, 2025
@python-cla-bot

python-cla-bot Bot commented Apr 18, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk

+3 more reviewers

@SylvainDe SylvainDe SylvainDe left review comments

@evildmp evildmp evildmp approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@TommyUnreal @hauntsaninja @evildmp @SylvainDe @hugovk @CaedenPH @willingc @serhiy-storchaka @bedevere-bot