◐ Shell
reader mode source ↗
Skip to content

gh-107253: Use Py_T_OBJECT_EX instead of _Py_T_OBJECT#107254

Closed
serhiy-storchaka wants to merge 3 commits into
python:mainfrom
serhiy-storchaka:Py_T_OBJECT_EX
Closed

gh-107253: Use Py_T_OBJECT_EX instead of _Py_T_OBJECT#107254
serhiy-storchaka wants to merge 3 commits into
python:mainfrom
serhiy-storchaka:Py_T_OBJECT_EX

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
Closed
@rhettinger rhettinger removed their request for review July 25, 2023 20:05
@encukou

encukou commented Nov 28, 2023

Copy link
Copy Markdown
Member

This is a behaviour change. It may break existing users.
It's OK to do the change in individual cases where the existing behaviour is problematic, but changing all the occurrences is just asking for trouble.
These are the cases that don't break tests, but IMO in many cases that means the tests are inadequate :)

Would you be OK closing this?

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
@encukou encukou closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@berkerpeksag berkerpeksag

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @encukou @bedevere-bot