bpo-30028: os.getpid() is always available#1074
Conversation
Sorry, something went wrong.
Remove hasattr(os, 'getpid') from logging.LogRecord constructor. The test was added in 2003 with the commit 4c641d0: "getpid doesn't exist on MacOS9", but Python 3.7 doesn't support MacOS9 anymore.
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vsajip, @benjaminp and @nnorwitz to be potential reviewers. |
Sorry, something went wrong.
|
"test.support uses [os.getpid()] unconditionally in various places. See https://github.com/python/cpython/blob/master/Lib/test/support/__init__.py#L803 for an example." |
Sorry, something went wrong.
|
The current code works well, whereas my change breaks the CloudABI. I prefer to keep the cheap test rather than breaking CloudABI, so I abandon my change. |
Sorry, something went wrong.
3 participants
Remove hasattr(os, 'getpid') from logging.LogRecord constructor. The
test was added in 2003 with the commit 4c641d0: "getpid doesn't
exist on MacOS9", but Python 3.7 doesn't support MacOS9 anymore.