◐ Shell
reader mode source ↗
Skip to content

gh-105751: Remove obsolete object base class in some ctypes tests#107460

Merged
ambv merged 1 commit into
python:mainfrom
tomasr8:ctypes-remove-object
Jul 31, 2023
Merged

gh-105751: Remove obsolete object base class in some ctypes tests#107460
ambv merged 1 commit into
python:mainfrom
tomasr8:ctypes-remove-object

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jul 30, 2023

Copy link
Copy Markdown
Member

Some classes in the ctypes tests still explicitly inherit from object which is a relic from Python 2.
Let's remove them. (This is a simple change so I think that a separate issue is not necessary?)

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jul 30, 2023
@ambv ambv changed the title ctypes: Remove obsolete object base class in some test cases Jul 31, 2023
@ambv ambv merged commit 520efec into python:main Jul 31, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @tomasr8 and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 520efecfc3aed34d3a44545c7cd872d1aea8c7dc 3.12

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @tomasr8 and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 520efecfc3aed34d3a44545c7cd872d1aea8c7dc 3.11

@tomasr8 tomasr8 deleted the ctypes-remove-object branch July 31, 2023 13:34
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
…types tests (pythonGH-107460)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-107501 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 31, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
…types tests (pythonGH-107460)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-107502 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2023
ambv added a commit that referenced this pull request Jul 31, 2023
…tests (GH-107460) (#107502)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
ambv added a commit that referenced this pull request Jul 31, 2023
…tests (GH-107460) (#107501)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants