{{ message }}
gh-105481: combine regen-opcode-targets with regen-opcode to avoid calculating the specialized opcodes in two places#107540
Merged
iritkatriel merged 3 commits intoAug 1, 2023
Conversation
Member
Sorry, something went wrong.
…oid calculating the specialized opcodes in two places
AraHaan
approved these changes
Aug 1, 2023
gvanrossum
approved these changes
Aug 1, 2023
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewer
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Python/makeopcodetargets.py (which is invoked by
make regen-opcode-targets) can be replaced by a few lines added toTools\build\generate_opcode_h.py, because most of its work is repeated there. This removes a make target and reduces code duplication.