GH-105848: Simplify the arrangement of CALL's stack#107788
Conversation
Sorry, something went wrong.
brandtbucher
added
performance
Performance or resource usage
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
labels
Aug 8, 2023
brandtbucher
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
August 8, 2023 23:02
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I think this can go in just like this.
Sorry, something went wrong.
|
How about some buildbot runs? |
Sorry, something went wrong.
brandtbucher
added
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
🔨 test-with-refleak-buildbots
Test PR w/ refleak buildbots; report in status section
labels
Aug 8, 2023
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit fd6607f 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit fd6607f 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
bedevere-bot
removed
🔨 test-with-refleak-buildbots
Test PR w/ refleak buildbots; report in status section
🔨 test-with-buildbots
labels
Aug 8, 2023
brandtbucher
added
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
🔨 test-with-refleak-buildbots
labels
Aug 9, 2023
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit a5a2d8f 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit a5a2d8f 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
bedevere-bot
removed
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
🔨 test-with-refleak-buildbots
Test PR w/ refleak buildbots; report in status section
labels
Aug 9, 2023
|
No new buildbot failures. |
Sorry, something went wrong.
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
A bunch of minor style issues, but nothing blocking.
Sorry, something went wrong.
Summary: This reflects the changes in python/cpython#107788. The changes to the relevant `LOAD_` instructions are mostly covered by updating `LoadMethodResult` to have a non-default constructor in 3.14+ which normalizes the content. Reviewed By: alexmalyshev Differential Revision: D80667929 fbshipit-source-id: 2d62f1850056792695faf8d9ceea61a0b4b31253
Reviewers
Assignees
4 participants
Instead of supporting both
[callable, self, args...]and[NULL, callable, args...], changeCALL's stack to be[callable, self_or_null, args...]. This always puts the desired callable at the same location on the stack, simplifying (or removing) the resulting shuffles and adjustments necessary for the shared code paths that follow.This also changes
CALL_FUNCTION_EX,DICT_MERGE,LOAD_ATTR,LOAD_GLOBAL,LOAD_SUPER_ATTRto support the new stack layout. In some cases, I've also changed the names of the stack items for consistency within a family.As a side-effect of the new layout,
LOAD_ATTR_PROPERTYandLOAD_ATTR_GETATTRIBUTE_OVERRIDDEN(which are both implemented as inlined calls) don't support pushing an additional item to the stack for a followingCALL(oparg & 1) anymore. I think this is fine, since it seems rare to call a "method" that's looked up in this manner.CALLsequence #105848