IGNORE: Call uops forever#107952
Conversation
Sorry, something went wrong.
This is only the first step for doing `CALL` in Tier 2. The next step involves tracing into the called code object. After that we'll have to do the remaining `CALL` specialization. Finally we'll have to tweak various things like `KW_NAMES`, and possibly move the `NULL` (for method calls) *above* the callable. But those are things for future PRs. Note: this moves setting `frame->return_offset` directly in front of `DISPATCH_INLINED()`, to make it easier to move it into `_PUSH_FRAME`.
Instead, the special case is an opcode using SAVE_FRAME_STATE(). Introducing #if TIER_ONE and #if TIER_TWO so we can implement _PUSH_FRAME differently for both tiers.
Instead, we special-case SAVE_IP: - Its Tier 2 expansion sets oparg to the instruction offset - In Tier 1 it is a no-op (and skipped if present in a macro)
gvanrossum
force-pushed
the
call-uops-forever
branch
from
aa8d8e7 to
7a226b1
Compare
August 15, 2023 20:23
gvanrossum
force-pushed
the
call-uops-forever
branch
from
7a226b1 to
0aae232
Compare
August 15, 2023 20:41
gvanrossum
force-pushed
the
call-uops-forever
branch
from
0aae232 to
f6a72ae
Compare
August 16, 2023 19:05
Reviewers
1 participant
(This is a variant of #107760 with -Xuops always enabled, to see if that would pass all tests. We should not merge this, as -Xuops is currently slower than the default interpreter.)