◐ Shell
reader mode source ↗
Skip to content

GH-92584: Remove Installing Python Modules (Distutils version)#108020

Merged
vstinner merged 5 commits into
python:mainfrom
AA-Turner:drop-install
Aug 16, 2023
Merged

GH-92584: Remove Installing Python Modules (Distutils version)#108020
vstinner merged 5 commits into
python:mainfrom
AA-Turner:drop-install

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 16, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This removes install/index, per the notice in the header:

The entire distutils package has been deprecated and will be removed in Python 3.12. This documentation is retained as a reference only, and will be removed with the package.

See #108018 to retain the install scheme content in the sysconfig docs.

A

📚 Documentation preview 📚: https://cpython-previews--108020.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news only security fixes labels Aug 16, 2023
@AA-Turner AA-Turner requested review from vstinner and zooba August 16, 2023 13:24
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
Closed
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member

The doc fails to build:

Doc/library/site.rst:188: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)
Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)

vstinner
vstinner approved these changes Aug 16, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@AA-Turner

AA-Turner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

@vstinner thanks, I've removed the references so the build succeeds, #108018 will restore them.

A

@AA-Turner
Merge branch 'main' into drop-install …
df3ce4f 
# Conflicts:
#	Doc/using/cmdline.rst
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member

A Docs job failed:

Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)

@AA-Turner

AA-Turner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

A Docs job failed:

Oh, I messed up the merge. Pushed a fix.

@vstinner vstinner enabled auto-merge (squash) August 16, 2023 21:03
@vstinner vstinner merged commit fbb7cbc into python:main Aug 16, 2023
@miss-islington

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fbb7cbc0e92168077fd56de942901511e99ca60a 3.12

@bedevere-bot

bedevere-bot commented Aug 16, 2023

Copy link
Copy Markdown

GH-108062 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Aug 16, 2023
@AA-Turner
[3.12] pythonGH-92584: Remove Installing Python Modules (Distutils ve… …
67df3e3 
…rsion) (pythonGH-108020).

(cherry picked from commit fbb7cbc)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Aug 17, 2023
@AA-Turner
[3.12] GH-92584: Remove Installing Python Modules (Distutils version) (… …
560e859 
…GH-108020) (#108062)

* [3.12] GH-92584: Remove Installing Python Modules (Distutils version) (GH-108020).
(cherry picked from commit fbb7cbc)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@zooba zooba Awaiting requested review from zooba

Assignees

@vstinner vstinner

Labels

Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner @vstinner @miss-islington @bedevere-bot