◐ Shell
reader mode source ↗
Skip to content

gh-108014: Add Py_IsFinalizing() function#108032

Merged
vstinner merged 5 commits into
python:mainfrom
vstinner:is_finalizing
Aug 18, 2023
Merged

gh-108014: Add Py_IsFinalizing() function#108032
vstinner merged 5 commits into
python:mainfrom
vstinner:is_finalizing

Conversation

@vstinner

@vstinner vstinner commented Aug 16, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
Closed
2 tasks
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

@ericsnowcurrently: Oh, that's a "feature" PR, so I will need a formal approval to merge it :-)

@vstinner vstinner mentioned this pull request Aug 16, 2023
Merged
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

I prepared python/pythoncapi-compat#66 to add the function to the pythoncapi-compat project.

@gvanrossum gvanrossum removed their request for review August 16, 2023 18:05
@kumaraditya303 kumaraditya303 removed their request for review August 17, 2023 06:08
serhiy-storchaka
serhiy-storchaka approved these changes Aug 17, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

vstinner and others added 2 commits August 17, 2023 22:01
@vstinner @serhiy-storchaka
Update Misc/NEWS.d/next/C API/2023-08-16-17-16-19.gh-issue-108014.wXN… …
fe6216c 
…3CF.rst

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner @serhiy-storchaka
Update Doc/whatsnew/3.13.rst …
fa76703 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner vstinner merged commit 3ff5ef2 into python:main Aug 18, 2023
@vstinner vstinner deleted the is_finalizing branch August 18, 2023 10:34
@vstinner

vstinner commented Aug 18, 2023

Copy link
Copy Markdown
Member Author

Thanks for the review @ericsnowcurrently and @serhiy-storchaka!

@vstinner vstinner mentioned this pull request Aug 29, 2023
Closed
@vstinner vstinner mentioned this pull request Sep 25, 2023
Closed
@vstinner

vstinner commented Oct 5, 2023

Copy link
Copy Markdown
Member Author

Follow-up: @wjakob asks to add this new function to the limited C API version 3.13.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 6, 2023
Open
@tacaswell tacaswell mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments

@serhiy-storchaka serhiy-storchaka

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc willingc is a code owner

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ericsnowcurrently @serhiy-storchaka @bedevere-bot