{{ message }}
[3.7] bpo-33015: Fix UB in pthread PyThread_start_new_thread (GH-6008)#10821
Merged
miss-islington merged 1 commit intoNov 30, 2018
Merged
Conversation
Contributor
Sorry, something went wrong.
Fix an undefined behaviour in the pthread implementation of PyThread_start_new_thread(): add a function wrapper to always return NULL. Add pythread_callback struct and pythread_wrapper() to thread_pthread.h. (cherry picked from commit 9eea6ea) Co-authored-by: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
vstinner
approved these changes
Nov 30, 2018
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM, good bot.
Sorry, something went wrong.
Contributor
Author
Sorry, something went wrong.
Contributor
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fix an undefined behaviour in the pthread implementation of
PyThread_start_new_thread(): add a function wrapper to always return
NULL.
Add pythread_callback struct and pythread_wrapper() to thread_pthread.h.
(cherry picked from commit 9eea6ea)
Co-authored-by: Siddhesh Poyarekar siddhesh.poyarekar@gmail.com
https://bugs.python.org/issue33015