◐ Shell
reader mode source ↗
Skip to content

gh-108494: Fix AC limited C API for kwargs#108516

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:clinic_limited_kwds
Closed

gh-108494: Fix AC limited C API for kwargs#108516
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:clinic_limited_kwds

Conversation

@vstinner

@vstinner vstinner commented Aug 26, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix the limited C API code path in Argument Clinic to parse "positional or keywords" arguments.

Add an unit test in _testclinic_limited.

@vstinner
pythongh-108494: Fix AC limited C API for kwargs …
21ad1fc 
Fix the limited C API code path in Argument Clinic to parse
"positional or keywords" arguments.

Add an unit test in _testclinic_limited.
@bedevere-bot bedevere-bot mentioned this pull request Aug 26, 2023
Closed
@vstinner

vstinner commented Aug 26, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland @AlexWaygood @serhiy-storchaka: Here is a fix for PyArg_ParseTupleAndKeywords(). It removes the unused argname_fmt in the PyArg_ParseTuple() code path.

@serhiy-storchaka

serhiy-storchaka commented Aug 27, 2023

Copy link
Copy Markdown
Member

See #108536.

@vstinner

vstinner commented Aug 27, 2023

Copy link
Copy Markdown
Member Author

Does your PR make this one useless, or should it be merged first?

@serhiy-storchaka

serhiy-storchaka commented Aug 27, 2023

Copy link
Copy Markdown
Member

I think that it makes it useless, maybe except the test. But for testing I want to reuse existing tests, so the current Modules/_testclinic_limited.c will become obsolete too.

@vstinner

vstinner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Serhiy's PR got merged and it's way more complete, I close this PR: #108536

@vstinner vstinner closed this Aug 28, 2023
@vstinner vstinner deleted the clinic_limited_kwds branch August 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @serhiy-storchaka @bedevere-bot