◐ Shell
reader mode source ↗
Skip to content

gh-106320: Remove private _PyLong_New() function#108604

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_long
Aug 29, 2023
Merged

gh-106320: Remove private _PyLong_New() function#108604
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_long

Conversation

@vstinner

@vstinner vstinner commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Move the following private API to the internal C API (pycore_long.h):

  • _PyLong_Copy()
  • _PyLong_FromDigits()
  • _PyLong_New()

No longer export most of these functions.

@vstinner
pythongh-106320: Remove private _PyLong_New() function …
001cf8c 
Move the following private API to the internal C API (pycore_long.h):

* _PyLong_Copy()
* _PyLong_FromDigits()
* _PyLong_New()

No longer export most of these functions.
@bedevere-bot bedevere-bot mentioned this pull request Aug 29, 2023
Closed
@vstinner vstinner merged commit 921eb8e into python:main Aug 29, 2023
@vstinner vstinner deleted the pycore_long branch August 29, 2023 02:59
@skirpichev

skirpichev commented Oct 23, 2023

Copy link
Copy Markdown
Member

@vstinner, we use _PyLong_New() in the gmpy2, e.g. in the GMPy_PyLong_From_MPZ() method. What's now the intended replacement for this private API?

@skirpichev skirpichev mentioned this pull request Oct 23, 2023
Merged
@skirpichev

skirpichev commented Oct 25, 2023

Copy link
Copy Markdown
Member

Another user is the sage:

$ git grep _PyLong_N
src/sage/libs/gmp/pylong.pyx:from cpython.longintrepr cimport _PyLong_New, py_long, digit, PyLong_SHIFT
src/sage/libs/gmp/pylong.pyx:    L = _PyLong_New(pylong_size)

@vstinner

vstinner commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

we use _PyLong_New() in the gmpy2, e.g. in the GMPy_PyLong_From_MPZ() method. What's now the intended replacement for this private API?

Would you mind to open a separated issue describing how you use _PyLong_New() and which API do you need? _PyLong_New() changed a lot in Python 3.12: see also issue #111140.

@vstinner vstinner mentioned this pull request Oct 27, 2023
Closed
@skirpichev skirpichev mentioned this pull request Oct 28, 2023
Closed
@skirpichev

skirpichev commented Oct 28, 2023

Copy link
Copy Markdown
Member

I've opened #111415

skirpichev added a commit to skirpichev/cpython that referenced this pull request Oct 28, 2023
@skirpichev
pythongh-111415: restoring _PyLong_New() as public …
cc5240c 
This partially reverts python#108604.
@vstinner vstinner mentioned this pull request Oct 30, 2023
Closed
@vstinner vstinner mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @skirpichev @bedevere-bot