◐ Shell
reader mode source ↗
Skip to content

gh-106320: Remove private _PyOS_IsMainThread() function#108605

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_signal
Aug 29, 2023
Merged

gh-106320: Remove private _PyOS_IsMainThread() function#108605
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_signal

Conversation

@vstinner

@vstinner vstinner commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Move the following private API to the internal C API (pycore_signal.h):

  • _PyOS_IsMainThread()
  • _PyOS_SigintEvent()

No longer export these functions.

@bedevere-bot bedevere-bot mentioned this pull request Aug 29, 2023
Closed
@vstinner
pythongh-106320: Remove private _PyOS_IsMainThread() function …
f3eaba7 
Move the following private API to the internal C API
(pycore_signal.h): _PyOS_IsMainThread() and _PyOS_SigintEvent().
@vstinner vstinner enabled auto-merge (squash) August 29, 2023 03:02
@vstinner vstinner merged commit fadc2dc into python:main Aug 29, 2023
@vstinner vstinner deleted the pycore_signal branch August 29, 2023 03:40
@jbms

jbms commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

This breaks tensorstore, specifically due to the usage of _PyOS_SigintEvent here: https://github.com/google/tensorstore/blob/798025f874c7579b2eb900932bf7c56d4f8ebd62/python/tensorstore/future.cc#L75

It is used in order to make a blocking wait within the main thread interruptible via Control+C on Windows. I don't know of any easy alternative. For now I will be using the workaround of copying the declaration to my own source file, but if the function is eventually removed entirely that won't work.

@vstinner

vstinner commented Dec 11, 2024

Copy link
Copy Markdown
Member Author

Would you mind to open a new issue since this one is closed? Please explain your use case and why you need this function to be exposed.

@vstinner

vstinner commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

Ping @jbms.

@jbms jbms mentioned this pull request Jan 9, 2025
Open
@jbms

jbms commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Ping @jbms.

Created #128684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @jbms @bedevere-bot