◐ Shell
reader mode source ↗
Skip to content

gh-109118: Disallow nested scopes within PEP 695 scopes within classes#109196

Merged
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:fixclassgenexp
Sep 12, 2023
Merged

gh-109118: Disallow nested scopes within PEP 695 scopes within classes#109196
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:fixclassgenexp

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 9, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Sep 9, 2023
@JelleZijlstra JelleZijlstra requested a review from carljm September 9, 2023 19:51
@bedevere-bot bedevere-bot mentioned this pull request Sep 9, 2023
Closed
@JelleZijlstra @carljm
Update Lib/test/test_type_params.py …
ea69d36 
Co-authored-by: Carl Meyer <carl@oddbird.net>
@JelleZijlstra JelleZijlstra merged commit b88d9e7 into python:main Sep 12, 2023
@miss-islington

miss-islington commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@JelleZijlstra JelleZijlstra deleted the fixclassgenexp branch September 12, 2023 00:11
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2023
@JelleZijlstra @carljm @miss-islington
pythongh-109118: Disallow nested scopes within PEP 695 scopes within … …
0dc03f4 
…classes (pythonGH-109196)

Fixes pythonGH-109118. Fixes pythonGH-109194.

(cherry picked from commit b88d9e7)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
@bedevere-app

bedevere-app Bot commented Sep 12, 2023

Copy link
Copy Markdown

GH-109297 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 12, 2023
Yhg1s pushed a commit that referenced this pull request Sep 12, 2023
@miss-islington @JelleZijlstra @carljm
[3.12] gh-109118: Disallow nested scopes within PEP 695 scopes within… …
8208657 
… classes (GH-109196) (#109297)

gh-109118: Disallow nested scopes within PEP 695 scopes within classes (GH-109196)

Fixes GH-109118. Fixes GH-109194.

(cherry picked from commit b88d9e7)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@JelleZijlstra @carljm @vstinner
pythongh-109118: Disallow nested scopes within PEP 695 scopes within … …
cc1f90e 
…classes (python#109196)

Fixes python#109118. Fixes python#109194.

Co-authored-by: Carl Meyer <carl@oddbird.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug with comprehension inlining + type aliases Annotation scopes containing nested scopes

4 participants

@JelleZijlstra @miss-islington @carljm @bedevere-bot