gh-78469: Declare missing sethostname for Solaris 10#109447
Conversation
|
When was Solaris 10 release? Is it still supported? Does this change better to forks of Solaris? |
Sorry, something went wrong.
Sorry for such a long delay. As mentioned in the issue, Solaris 10, while in the "extended support stage" intended mostly for critical fixes, is still supported (ATM at least until January 2025). There are still people using it and possibly installing newer Python onto it. As for the Solaris forks, this doesn't affect those because the first open version was Solaris 11. |
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
|
Is this a bug-fix? If so, we should backport it and add a NEWS entry. |
Sorry, something went wrong.
Do you use "make regen-configure"? See: https://docs.python.org/dev/using/configure.html#generated-files @kulikjak: Anyway, I push directly into your branch to fix the configure script (regenerate it). |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
|
@kulikjak: I also replaced |
Sorry, something went wrong.
Sigh, sorry. Normally, I do, but this time I thought that I could quickly edit it myself, ... and I was wrong. Thanks for fixing it.
I guess it is (fixing a build on Solaris <= 10). I can add a NEWS entry, although now there is a Other than that, the build failure doesn't seem to be related, so that's good. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x SLES 3.x has failed when building commit 3b1580a. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/540/builds/6801 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_signal.py", line 1374, in test_stress_modifying_handlers
self.assertGreater(num_received_signals, 0)
AssertionError: 0 not greater than 0
|
Sorry, something went wrong.
…9447) Add OS version specific macro for Solaris: Py_SUNOS_VERSION.
As discussed in the issue,
sethostnameis missing from Solaris 10 headers but is available on Solaris 11.And because there isn't an OS version specific macro for Solaris, I had to "create" one.