◐ Shell
reader mode source ↗
Skip to content

bpo-9566: Fix compiler warnings in peephole.c#11011

Closed
jkloth wants to merge 1 commit into
python:masterfrom
jkloth:issue9566-peephole
Closed

bpo-9566: Fix compiler warnings in peephole.c#11011
jkloth wants to merge 1 commit into
python:masterfrom
jkloth:issue9566-peephole

Conversation

@jkloth

@jkloth jkloth commented Dec 7, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Fixes compiler warnings in peephole.c when compiled for 64-bit.

https://bugs.python.org/issue9566

@serhiy-storchaka

serhiy-storchaka commented Dec 7, 2018

Copy link
Copy Markdown
Member

This is a duplicate of #10652.

@vstinner

vstinner commented Dec 7, 2018

Copy link
Copy Markdown
Member

@jkloth: Would you be ok to close this PR in favor in mine, PR #10652?

@bedevere-bot

bedevere-bot commented Dec 7, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner

vstinner commented Dec 7, 2018

Copy link
Copy Markdown
Member

This PR has multiple issues that I already fixed in my PR. So I close this one, sorry @jkloth. I prefer to focus on a single PR :)

@vstinner vstinner closed this Dec 7, 2018
@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkloth @serhiy-storchaka @vstinner @bedevere-bot @the-knights-who-say-ni