gh-109286 Updated macOS and Windows installers to SQLite 3.43.1 #110252
Conversation
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
|
Seems to be having an issue with the checksum variable. I copied that hash code directly from the site : https://sqlite.org/download.html. It is the correct hash assigned to the .tar.gz file for the source code download for version 3.43.1. |
Sorry, something went wrong.
felixxm
left a comment
There was a problem hiding this comment.
@jtranquilli Thanks 👍 Please split it into two PRs, one for Windows and one for macOS installer.
Sorry, something went wrong.
Doing both in one PR is fine. There are several failing checks right now, though:
|
Sorry, something went wrong.
I've been asked to do it separately in the past 🤷 |
Sorry, something went wrong.
|
Splitting is also fine :). It's largely a matter of personal taste; I'll be happy to merge a unified PR when it's clean and ready, but another core dev may well prefer a split. |
Sorry, something went wrong.
|
We typically have two separate NEWS entries for these changes, as they affect the release more than build. You can add two entries in the same PR (just change the random characters near the end of the filename), but people are probably going to be more comfortable with one NEWS entry per PR, just because they won't have seen multiple ones so often. |
Sorry, something went wrong.
|
I usually split these PRs, since the response time of the Windows and macOS teams can vary greatly :) |
Sorry, something went wrong.
I just updated my .gitconfig file to use my GitHub email so that I should be able to sign the CLA now, but this PR is still associated with some other default email. Is the best way forward to create a new pull request with the updated associated email or is there some way to salvage this request? |
Sorry, something went wrong.
|
Depends on the level of Git wizardry that you're comfortable with :). You can recreate the commits and force-push, or you can take the opportunity to split it up and push fresh commits to two new branches and thus new PRs. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
Updated macOS and Windows installers to SQLite 3.43.1
The issue is gh-109286