gh-89902: Deprecate non-standard format specifier "N" for Decimal#110508
Conversation
It was not documented and only supported in the C implementation.
mdickinson
left a comment
There was a problem hiding this comment.
Code LGTM, and I agree with the change.
Sorry, something went wrong.
mdickinson
left a comment
There was a problem hiding this comment.
Trying again: LGTM
(Something funny is going on with our automation here. Why is this labelled as "awaiting core review"?)
Sorry, something went wrong.
|
Ignore it. The bot is broken for months already. Thank you for your review. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x Fedora Clang 3.x has failed when building commit d96a8cd. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/3/builds/4770 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/test_subprocess.py", line 769, in test_pipesize_default
self.assertEqual(
AssertionError: 65536 != 8192
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/test_subprocess.py", line 727, in test_pipesizes
p = subprocess.Popen(
^^^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/subprocess.py", line 992, in __init__
errread, errwrite) = self._get_handles(stdin, stdout, stderr)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/subprocess.py", line 1731, in _get_handles
fcntl.fcntl(errwrite, fcntl.F_SETPIPE_SZ, self.pipesize)
PermissionError: [Errno 1] Operation not permitted
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.x has failed when building commit d96a8cd. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/524/builds/4666 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_os.py", line 4085, in test_timerfd_select
self.assertGreater(t, total_time)
AssertionError: 0.49994910099485423 not greater than 0.5
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot aarch64 RHEL8 LTO 3.x has failed when building commit d96a8cd. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/338/builds/5284 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIME
self.assertGreater(t, offset)
AssertionError: 0.9999961559951771 not greater than 1
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit d96a8cd. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/506/builds/6083 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_os.py", line 4211, in test_timerfd_ns_TFD_TIMER_ABSTIME
self.assertGreater(t, offset_ns)
AssertionError: 999973587 not greater than 1000000000
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIME
self.assertGreater(t, offset)
AssertionError: 0.9999069161713123 not greater than 1
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot PPC64LE Fedora Stable Clang 3.x has failed when building commit d96a8cd. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/435/builds/3713 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang/build/Lib/test/test_os.py", line 4211, in test_timerfd_ns_TFD_TIMER_ABSTIME
self.assertGreater(t, offset_ns)
AssertionError: 999993323 not greater than 1000000000
|
Sorry, something went wrong.
…al (pythonGH-110508) It was not documented and only supported in the C implementation.
It was not documented and only supported in the C implementation.
📚 Documentation preview 📚: https://cpython-previews--110508.org.readthedocs.build/