◐ Shell
reader mode source ↗
Skip to content

gh-107652: Fix CIFuzz build#110576

Merged
hugovk merged 3 commits into
python:mainfrom
sobolevn:fix-ci-fuzz-build
Oct 10, 2023
Merged

gh-107652: Fix CIFuzz build#110576
hugovk merged 3 commits into
python:mainfrom
sobolevn:fix-ci-fuzz-build

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

When CI job was skipped the job was failing: https://github.com/python/cpython/actions/runs/6459321247/job/17536559744?pr=110573

Error: The template is not valid. .github/workflows/build.yml (Line: 620, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

This happened because run_cifuzz was not set. Now we use the same logic as for other tools by setting it to false

Refs #107653
Refs #107652

@bedevere-app bedevere-app Bot added the label Oct 9, 2023
hugovk
hugovk requested changes Oct 9, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

There's an error with this, please could you check?

@hugovk

hugovk commented Oct 9, 2023

Copy link
Copy Markdown
Member

cc @illia-v

illia-v
illia-v approved these changes Oct 9, 2023
View reviewed changes

@illia-v illia-v left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I'm sorry for the error. Thank you for the fix!

hugovk
hugovk approved these changes Oct 10, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks!

@hugovk hugovk merged commit def7ea5 into python:main Oct 10, 2023
@sobolevn

sobolevn commented Oct 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Btw, I use https://explainshell.com/explain?cmd=grep+-qE all the time, can recommend for bash reviews :)

Thanks, everyone!

@sobolevn

sobolevn commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

I can verify that my C changes now trigger CIFuzz: #110573

@hugovk

hugovk commented Oct 10, 2023

Copy link
Copy Markdown
Member

#109854 was created before merging CIFuzz, it changed .pre-commit-config.yaml and Tools/patchcheck/patchcheck.py.

I updated it from main, and it did the CIFuzz checks, somewhat surprisingly.

Do you know why?

@hugovk hugovk mentioned this pull request Oct 10, 2023
Merged
@hugovk hugovk changed the title Fix CIFuzz build Oct 10, 2023
@illia-v

illia-v commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

@hugovk I guess it happened because the merge commit contained changes to the relevant files

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
Fix CIFuzz build (python#110576)
794d3cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

+1 more reviewer

@illia-v illia-v illia-v approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @hugovk @illia-v