◐ Shell
reader mode source ↗
Skip to content

bpo-16379: Expose sqlite error code #1108

Closed
palaviv wants to merge 5 commits into
python:mainfrom
palaviv:bpo-16379-expose-sqlite-error-code
Closed

bpo-16379: Expose sqlite error code #1108
palaviv wants to merge 5 commits into
python:mainfrom
palaviv:bpo-16379-expose-sqlite-error-code

Conversation

@palaviv

@palaviv palaviv commented Apr 13, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This PR adds the sqlite error code and name to the exceptions raised by the sqlite3 module. Once this is merged my hope is to expose the sqlite extended error code as discussed in bpo-24139

https://bugs.python.org/issue16379

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 8, 2018
auvipy
auvipy suggested changes Apr 28, 2019
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

plz rebase!

@matrixise matrixise changed the title bpo-16379: Expose sqlite error code May 7, 2019
@matrixise

matrixise commented May 7, 2019

Copy link
Copy Markdown
Member

Hi @palaviv

Would you be interested to upgrade your PR to the last master?

Thank you

@matrixise matrixise requested a review from berkerpeksag May 7, 2019 20:48
@palaviv palaviv force-pushed the bpo-16379-expose-sqlite-error-code branch from 365ad2a to c236045 Compare May 8, 2019 12:22
@palaviv

palaviv commented May 8, 2019

Copy link
Copy Markdown
Contributor Author

Sure @matrixise. Do you think there is a chance for this to be merged?

@palaviv palaviv force-pushed the bpo-16379-expose-sqlite-error-code branch from b9dc556 to 31467e3 Compare May 9, 2019 09:55
@dimaqq

dimaqq commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

If I remember https://bugs.python.org/issue24139 correctly, the issue was rather about exposing the extended error codes http://www.sqlite.org/c3ref/c_abort_rollback.html

@palaviv

palaviv commented Jun 11, 2019

Copy link
Copy Markdown
Contributor Author

@dimaqq you are correct. This is a patch for https://bugs.python.org/issue16379. There is a different patch that depends on this change to solve https://bugs.python.org/issue24139.

@nelsonjchen nelsonjchen mentioned this pull request Jan 12, 2020
Closed
@dpusceddu

dpusceddu commented Apr 22, 2020

Copy link
Copy Markdown

I'd really really like to have this feature...

@erlend-aasland

erlend-aasland commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

@palaviv: Can you rebase onto master and update your code to PEP 7 standards? Also, the #ifdefs are not needed as SQLite 3.7.15 is now a hard requirement.

@erlend-aasland

erlend-aasland commented Aug 6, 2021

Copy link
Copy Markdown
Contributor

@palaviv, are you planning on landing this PR? If not, would you mind if I reopened a PR with your changes cherry-picked onto it?

@erlend-aasland erlend-aasland mentioned this pull request Aug 16, 2021
Merged
@erlend-aasland

erlend-aasland commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Closing this, as #27786 (based off of this PR) has now been merged. Thank you for your work, @palaviv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

+3 more reviewers

@dimaqq dimaqq dimaqq left review comments

@danielshahaf danielshahaf danielshahaf left review comments

@auvipy auvipy auvipy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.