◐ Shell
reader mode source ↗
Skip to content

gh-85283: Fix Argument Clinic for md5 extension#110976

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_md5_clinic
Oct 17, 2023
Merged

gh-85283: Fix Argument Clinic for md5 extension#110976
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_md5_clinic

Conversation

@vstinner

@vstinner vstinner commented Oct 17, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Limited C API supports the defining class under some conditions.

@vstinner
pythongh-85283: Fix Argument Clinic for md5 extension …
e50946f 
Limited C API supports the defining class under some conditions.
@bedevere-app bedevere-app Bot mentioned this pull request Oct 17, 2023
Closed
@vstinner

vstinner commented Oct 17, 2023

Copy link
Copy Markdown
Member Author

I'm not sure how I managed PR #110967 with outdated Argument Clinic file (Modules/clinic/md5module.c.h). It seems like make clinic failed and I didn't noticed that it failed! Moreover, I expected "Check if generated files are up to date" does run make clinic but apparently it does not!

@vstinner

vstinner commented Oct 17, 2023

Copy link
Copy Markdown
Member Author

I'm not sure how I managed PR #110967 with outdated Argument Clinic file (Modules/clinic/md5module.c.h).

Ah, in fact, the file got regenerated, it's just that a warning was emitted:

Warning in file 'Modules/md5module.c' on line 114:
Function MD5Type.copy cannot use limited C API

It's not an error. The problem is that with PR #110966, it becomes an error.

@vstinner vstinner enabled auto-merge (squash) October 17, 2023 11:34
AlexWaygood
AlexWaygood reviewed Oct 17, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

two nits:

@AlexWaygood AlexWaygood disabled auto-merge October 17, 2023 11:39
@vstinner vstinner merged commit 054f496 into python:main Oct 17, 2023
@vstinner vstinner deleted the fix_md5_clinic branch October 17, 2023 11:46
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-85283: Fix Argument Clinic for md5 extension (python#110976) …
3c0a3cd 
Limited C API supports the defining class under some conditions.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-85283: Fix Argument Clinic for md5 extension (python#110976) …
c54f498 
Limited C API supports the defining class under some conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @AlexWaygood