{{ message }}
gh-102980: Redirect pdb interact command, add tests and improve docs#111194
Merged
iritkatriel merged 9 commits intoDec 7, 2023
Merged
gh-102980: Redirect pdb interact command, add tests and improve docs#111194iritkatriel merged 9 commits into
interact command, add tests and improve docs#111194iritkatriel merged 9 commits into
Conversation
Member
Author
|
Hi @iritkatriel , could you maybe take a look at this PR when you have some time? It's a relatively straightforward one and it's been stuck for a while. Thanks! |
Sorry, something went wrong.
iritkatriel
reviewed
Dec 6, 2023
iritkatriel
approved these changes
Dec 6, 2023
iritkatriel
reviewed
Dec 6, 2023
iritkatriel
reviewed
Dec 7, 2023
Member
Author
|
Thanks for the review! |
Sorry, something went wrong.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ts and improve docs (python#111194)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ts and improve docs (python#111194)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
With the long due #102896, we can finally add tests for
interactcommand.However, the current
interactcommand usescode.interactdirectly which makes it super difficult to test, becausecode.interactwrites tosys.stderrdirectly (withsys.stderr.write)! We need to overload thewritemethod in a derived class to write to the same channel asPdb.message.The interactive message is also changed to make more sense - one might wonder if this is a breaking change to users, but
interactcommand, so I don't think we'll break anything.This PR adds the class for interact commmand and some basic tests for
interact; and also clarifies the namespace situation withinteract- it's a bit tricky and could be confusing to the users, so some clarification is needed.The way to exit
interactcommand is also added to the docs.📚 Documentation preview 📚: https://cpython-previews--111194.org.readthedocs.build/