◐ Shell
reader mode source ↗
Skip to content

bpo-35471: Remove the macpath module#11129

Merged
vstinner merged 2 commits into
python:masterfrom
vstinner:remove_macpath
Dec 14, 2018
Merged

bpo-35471: Remove the macpath module#11129
vstinner merged 2 commits into
python:masterfrom
vstinner:remove_macpath

Conversation

@vstinner

@vstinner vstinner commented Dec 12, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.

https://bugs.python.org/issue35471

@vstinner
bpo-35471: Remove the macpath module …
cf5fce8 
Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.
@vstinner vstinner requested a review from a team as a code owner December 12, 2018 15:26
@serhiy-storchaka serhiy-storchaka requested a review from a team December 12, 2018 16:08
@vstinner

vstinner commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: I made two changes, see my second commit.

ned-deily
ned-deily approved these changes Dec 13, 2018
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, thanks

@vstinner

vstinner commented Dec 14, 2018

Copy link
Copy Markdown
Member Author

@ronaldoussoren wrote "I'm in favour of removing macpath.":
https://bugs.python.org/issue35471#msg331702

@vstinner vstinner merged commit d7538dd into python:master Dec 14, 2018
@vstinner vstinner deleted the remove_macpath branch December 14, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@ned-deily ned-deily ned-deily approved these changes

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @serhiy-storchaka @ned-deily @the-knights-who-say-ni @bedevere-bot