◐ Shell
reader mode source ↗
Skip to content

gh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent of -X frozen_modules.#111411

Merged
gpshead merged 13 commits into
python:mainfrom
yilei:frozen
Nov 1, 2023
Merged

gh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent of -X frozen_modules.#111411
gpshead merged 13 commits into
python:mainfrom
yilei:frozen

Conversation

@yilei

@yilei yilei commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

It seems that config_get_env can't distinguish between "not set" and "set to an empty string"? So PYTHON_FROZEN_MODULES= means differently than -X frozen_modules without values. I'm not sure if this could create confusion, but on the other hand the use of -X frozen_modules or -X frozen_modules= with empty values isn't explicitly documented.


📚 Documentation preview 📚: https://cpython-previews--111411.org.readthedocs.build/

@gpshead gpshead self-assigned this Oct 28, 2023
@hugovk hugovk changed the title gh-111374: Add a new PYTHONFROZENMODULES env var, equivalent of -X frozen_modules. Oct 29, 2023
@hugovk

hugovk commented Oct 29, 2023

Copy link
Copy Markdown
Member

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the docs changes. Looks good, just some little nits.

yilei and others added 4 commits October 29, 2023 17:04
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…e-111374.e9lrPZ.rst

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@yilei

yilei commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, -X frozen_modules is also updated. Please take another look.

@yilei yilei requested a review from gpshead November 1, 2023 20:00
@gpshead gpshead enabled auto-merge (squash) November 1, 2023 20:12
@gpshead gpshead merged commit 45a36d5 into python:main Nov 1, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
…of `-X frozen_modules`. (python#111411)

Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@yilei yilei deleted the frozen branch December 12, 2023 20:46
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…of `-X frozen_modules`. (python#111411)

Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants