◐ Shell
reader mode source ↗
Skip to content

gh-111495: Add tests for PyComplex C API#111591

Merged
serhiy-storchaka merged 16 commits into
python:mainfrom
skirpichev:capi-complex-tests
Nov 5, 2023
Merged

gh-111495: Add tests for PyComplex C API#111591
serhiy-storchaka merged 16 commits into
python:mainfrom
skirpichev:capi-complex-tests

Conversation

@skirpichev

@skirpichev skirpichev commented Nov 1, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@skirpichev

skirpichev commented Nov 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

On top of #111586 - that's why marked as a draft pr.

@skirpichev skirpichev mentioned this pull request Nov 1, 2023
Closed
10 tasks
@skirpichev skirpichev changed the title Add tests for PyComplex C API Nov 1, 2023
@skirpichev skirpichev marked this pull request as ready for review November 1, 2023 06:26
@serhiy-storchaka serhiy-storchaka self-requested a review November 1, 2023 14:28
@skirpichev skirpichev mentioned this pull request Nov 2, 2023
Merged
@skirpichev skirpichev mentioned this pull request Nov 4, 2023
Closed
@AlexWaygood AlexWaygood added tests Tests in the Lib/test dir skip news labels Nov 4, 2023
skirpichev and others added 2 commits November 4, 2023 14:27
@skirpichev @serhiy-storchaka
Apply suggestions from code review …
7694c60 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@skirpichev
+1
70796bd
5 hidden items Load more…
@skirpichev skirpichev mentioned this pull request Nov 4, 2023
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Nov 5, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) November 5, 2023 07:21
@serhiy-storchaka serhiy-storchaka merged commit 24b5cbd into python:main Nov 5, 2023
@miss-islington-app

miss-islington-app Bot commented Nov 5, 2023

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2023
@skirpichev @miss-islington
pythongh-111495: Add tests for PyComplex C API (pythonGH-111591) …
269b69d 
(cherry picked from commit 24b5cbd)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app

bedevere-app Bot commented Nov 5, 2023

Copy link
Copy Markdown

GH-111753 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 5, 2023
serhiy-storchaka pushed a commit that referenced this pull request Nov 5, 2023
@miss-islington @skirpichev
[3.12] gh-111495: Add tests for PyComplex C API (GH-111591) (GH-111753) …
e0c2bf4 
(cherry picked from commit 24b5cbd)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@skirpichev skirpichev deleted the capi-complex-tests branch November 5, 2023 09:58
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 5, 2023
@skirpichev
Merge branch 'main' into complex-realimag-asdouble …
6be9ee2 
This include python#111591
@skirpichev skirpichev mentioned this pull request Nov 14, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@skirpichev @aisk
pythongh-111495: Add tests for PyComplex C API (pythonGH-111591)
cc255cb
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@skirpichev @Glyphack
pythongh-111495: Add tests for PyComplex C API (pythonGH-111591)
7748a29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @serhiy-storchaka @AlexWaygood