◐ Shell
reader mode source ↗
Skip to content

gh-111495: Add tests for PyTuple C API#111606

Closed
rawwar wants to merge 11 commits into
python:mainfrom
rawwar:kalyan/test-capi-tuple
Closed

gh-111495: Add tests for PyTuple C API#111606
rawwar wants to merge 11 commits into
python:mainfrom
rawwar:kalyan/test-capi-tuple

Conversation

@rawwar

@rawwar rawwar commented Nov 1, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Adding tests for PyTuple C API - Issue #111495

@rawwar
init …
8cbb0b8 
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@bedevere-app bedevere-app Bot mentioned this pull request Nov 1, 2023
Closed
10 tasks
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Nov 1, 2023
rawwar added 7 commits November 1, 2023 22:16
@rawwar
add check test …
ebb84ac 
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@rawwar
update c tests …
480f80b 
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@rawwar
Merge branch 'main' into kalyan/test-capi-tuple
db34897
@rawwar
add test …
497f009 
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@rawwar
add tests …
ed3b9ba 
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@rawwar
add tests …
1073d78 
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@rawwar
Merge branch 'main' into kalyan/test-capi-tuple
9b3f1da
@rawwar

rawwar commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

Hello @serhiy-storchaka , I am not sure how to write tests for the following C API's. Can you please help me with some ideas. Thanks!

  1. PyTuple_Pack
  2. PyTuple_SetItem
  3. PyTuple_SET_ITEM
  4. PyTuple_Resize

@rawwar rawwar marked this pull request as ready for review November 1, 2023 19:27
@rawwar rawwar marked this pull request as draft November 4, 2023 04:01
@skirpichev

skirpichev commented Feb 20, 2024

Copy link
Copy Markdown
Member

@rawwar, are you working on this? Regarding ideas, you could take look on other tests for C-API, e.g. for lists.

@rawwar

rawwar commented Feb 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rawwar, are you working on this? Regarding ideas, you could take look on other tests for C-API, e.g. for lists.

Thanks. I will go through them. Will be looking into this over the weekend

@rawwar

rawwar commented May 8, 2024

Copy link
Copy Markdown
Contributor Author

I won't be able to complete this PR at this time.

@rawwar rawwar closed this May 8, 2024
@skirpichev

skirpichev commented May 8, 2024

Copy link
Copy Markdown
Member

I'll try to finish your work.

@skirpichev skirpichev mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rawwar @skirpichev