◐ Shell
reader mode source ↗
Skip to content

gh-111615: Fix regression in QueueHandler configuration.#111638

Merged
vsajip merged 1 commit into
python:mainfrom
vsajip:fix-111615
Dec 27, 2023
Merged

gh-111615: Fix regression in QueueHandler configuration.#111638
vsajip merged 1 commit into
python:mainfrom
vsajip:fix-111615

Conversation

@vsajip

@vsajip vsajip commented Nov 2, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@vsajip vsajip added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 3.12 only security fixes 3.13 bugs and security fixes labels Nov 2, 2023
@bedevere-bot

bedevere-bot commented Nov 2, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vsajip for commit 7d19184 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-app bedevere-app Bot mentioned this pull request Nov 2, 2023
Closed
@vsajip vsajip requested review from encukou and iritkatriel November 2, 2023 20:35
@vsajip

vsajip commented Nov 10, 2023

Copy link
Copy Markdown
Member Author

Buildbot failures seem to be either Python build issues, or unrelated failures in test.test_asyncio.test_streams.

@vsajip vsajip merged commit 67655d8 into python:main Dec 27, 2023
@vsajip vsajip deleted the fix-111615 branch December 27, 2023 09:35
@vsajip vsajip added the needs backport to 3.12 only security fixes label Dec 27, 2023
@miss-islington-app

miss-islington-app Bot commented Dec 27, 2023

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Dec 27, 2023

Copy link
Copy Markdown

GH-113507 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 27, 2023
vsajip pushed a commit that referenced this pull request Dec 27, 2023
@miss-islington
[3.12] gh-111615: Fix regression in QueueHandler configuration. (GH-1… …
ba3e19a 
…11638) (GH-113507)
@brettcannon brettcannon mentioned this pull request Jan 3, 2024
Closed
@brettcannon

brettcannon commented Jan 3, 2024

Copy link
Copy Markdown
Member

This broke the WASI builds as multiprocessing isn't available. Opened #113692 to track the breakage.

https://buildbot.python.org/all/#/builders/1046/builds/3844

======================================================================
ERROR: test_111615 (test.test_logging.ConfigDictTest.test_111615)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_logging.py", line 3934, in test_111615
    'queue': mp.get_context('spawn').Queue(),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/Lib/multiprocessing/context.py", line 102, in Queue
    from .queues import Queue
  File "/Lib/multiprocessing/queues.py", line 23, in <module>
    import _multiprocessing
ModuleNotFoundError: No module named '_multiprocessing'
----------------------------------------------------------------------

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@vsajip @kulikjak
pythongh-111615: Fix regression in QueueHandler configuration. (pytho… …
9f96af0 
…nGH-111638)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vsajip @aisk
pythongh-111615: Fix regression in QueueHandler configuration. (pytho… …
b15472a 
…nGH-111638)
@shmilee shmilee mentioned this pull request May 31, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vsajip @Glyphack
pythongh-111615: Fix regression in QueueHandler configuration. (pytho… …
834c431 
…nGH-111638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@encukou encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

3.12 only security fixes 3.13 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vsajip @bedevere-bot @brettcannon