◐ Shell
reader mode source ↗
Skip to content

bpo-35348: Fix platform.architecture() on macOS#11186

Closed
vstinner wants to merge 3 commits into
python:masterfrom
vstinner:platform_architecture
Closed

bpo-35348: Fix platform.architecture() on macOS#11186
vstinner wants to merge 3 commits into
python:masterfrom
vstinner:platform_architecture

Conversation

@vstinner

@vstinner vstinner commented Dec 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Fix platform.architecture() for macOS universal binaries: it no
longer uses the system's "file" command if the executable parameter
is not set.

https://bugs.python.org/issue35348

@vstinner
bpo-35348: Fix platform.architecture() on macOS …
778dfb5 
Fix platform.architecture() for macOS universal binaries: it no
longer uses the system's "file" command if the executable parameter
is not set.
@vstinner vstinner changed the title bpo-35348: platform.architecture() don't use file Dec 17, 2018
@vstinner vstinner requested a review from ned-deily December 17, 2018 09:41
@serhiy-storchaka

serhiy-storchaka commented Dec 17, 2018

Copy link
Copy Markdown
Member

Technically LGTM, but I do not know whether the behavior change is desirable.

@vstinner

vstinner commented Dec 17, 2018

Copy link
Copy Markdown
Member Author

Technically LGTM, but I do not know whether the behavior change is desirable.

Me neither :-) I would like to get a review of a macOS expert. It seems like @ronaldoussoren dislike the change:
https://bugs.python.org/issue35348#msg331959

@vstinner

vstinner commented Dec 18, 2018

Copy link
Copy Markdown
Member Author

@ronaldoussoren dislike this approach:
https://bugs.python.org/issue35348#msg331959

@malemburg also seems to dislike this change:
https://bugs.python.org/issue35348#msg332016

So I abandon this change.

@vstinner vstinner closed this Dec 18, 2018
@vstinner vstinner deleted the platform_architecture branch December 18, 2018 11:11
@vstinner

vstinner commented Dec 18, 2018

Copy link
Copy Markdown
Member Author

See PR #11208 which update the doc instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot