{{ message }}
gh-108901: Deprecate inspect.getargs, slate it for removal in 3.15#112279
Closed
sobolevn wants to merge 6 commits into
Closed
gh-108901: Deprecate inspect.getargs, slate it for removal in 3.15#112279sobolevn wants to merge 6 commits into
inspect.getargs, slate it for removal in 3.15#112279sobolevn wants to merge 6 commits into
Conversation
AlexWaygood
reviewed
Nov 22, 2023
AlexWaygood
reviewed
Nov 22, 2023
AlexWaygood
reviewed
Nov 22, 2023
AlexWaygood
reviewed
Nov 22, 2023
AlexWaygood
reviewed
Nov 22, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Nov 22, 2023
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! As discussed in https://github.com/python/cpython/pull/112279/files#r1402002908, however, let's deprecate getargvalues() first 👍
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Member
|
@sobolevn: This change has been approved but was never merged. It's now outdated since it mentions Python 3.13. Do you still plan to work on this PR? If not, I suggest closing it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Following the discussion of #108902, I documented that
getargsis deprecated (since it is not documented anywhere, I just modified its docstring) and thatinspect.signature(types.FunctionType(co, {}))is the modern alternative. I think that it is safe to remove this function in two versions, because it does not work anyway (pos-only, kw-only params are incorrect).I also don't think that modernizing
getargvaluesis valuable, because it will also be deprecated in 3.13 and hopefully removed in 3.15 as well.CC @AlexWaygood @merwok @vstinner who reviewed the first PR.
inspectmodule, deprecate old incorrect APIs #108901