bpo-14094: Use _getfinalpathname to implement realpath#11248
Conversation
zooba
left a comment
There was a problem hiding this comment.
I can't get to bpo right now to check the discussion, but the change looks fine.
Sorry, something went wrong.
|
A missing bit - handling of UNC paths with |
Sorry, something went wrong.
|
I can update this PR with a suggested approach of people don't mind. |
Sorry, something went wrong.
Co-Authored-By: vladima <v2matveev@outlook.com>
|
is there anything else that should be done for this PR? |
Sorry, something went wrong.
Sorry, something went wrong.
|
I think all comments are addressed, is there anything else? |
Sorry, something went wrong.
Feedback from core devs would be appreciated (@vstinner, @serhiy-storchaka, @zooba, @ZackerySpytz, @pfmoore, @tjguk, @zware). The short-name test needs to be hardened to get the short name of the directory via Skip the test if I think more cases need to be tested, including adapting tests from posixpath, if any are relevant.
|
Sorry, something went wrong.
zooba
left a comment
There was a problem hiding this comment.
I'd also like to see more tests. We're covering a lot of edge-cases here now, but not checking them all.
Sorry, something went wrong.
Sorry, something went wrong.
|
This no longer applies, but thanks for all the effort you put into the change (and dealing with our feedback)! |
Sorry, something went wrong.
Per discussion
realpathshould be usingGetFinalPathNameByHandleand it is already exposed via_getfinalpathname.https://bugs.python.org/issue14094