◐ Shell
reader mode source ↗
Skip to content

gh-108901: Deprecate inspect.getargvalues and inspect.formatargvalues, provide modern alternative#112639

Closed
sobolevn wants to merge 6 commits into
python:mainfrom
sobolevn:issue-108901-getargsvalues
Closed

gh-108901: Deprecate inspect.getargvalues and inspect.formatargvalues, provide modern alternative#112639
sobolevn wants to merge 6 commits into
python:mainfrom
sobolevn:issue-108901-getargsvalues

Conversation

@sobolevn

@sobolevn sobolevn commented Dec 3, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 3, 2023
Open
@vkhodygo

vkhodygo commented Feb 21, 2024

Copy link
Copy Markdown

Any progress?

@sobolevn sobolevn requested review from AlexWaygood and hugovk March 9, 2024 08:01
@sobolevn

sobolevn commented Mar 9, 2024

Copy link
Copy Markdown
Member Author

@hugovk I've implemented your suggestion about porting to Python 3.13, please take a look.
@AlexWaygood We discussed this deprecation in #112279

vstinner
vstinner reviewed Mar 9, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please start with a separated PR which adds Signature.from_frame(). Once it will be merge, you can simplify this PR to only deprecate methods.

@hugovk

hugovk commented Mar 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

(Copying and pasting my reply from elsewhere :)

PEP 387 says two releases of deprecation is the minimum but also:

  • If the deprecated feature is replaced by a new one, it should generally be removed only after the last Python version without the new feature reaches end of support.

Does that apply here? If so, and if the replacement is added in 3.13, then the removals should be when 3.13 is EOL in October 2029, meaning removal in 3.18, not 3.15.

@sobolevn sobolevn mentioned this pull request Mar 9, 2024
Open
@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
@vstinner

vstinner commented Apr 30, 2026

Copy link
Copy Markdown
Member

@sobolevn: This change is now outdated since it refers to Python 3.13. Do you still plan to work on this PR? If not, I suggest closing it.

@sobolevn sobolevn closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@gpshead gpshead Awaiting requested review from gpshead

@isidentical isidentical Awaiting requested review from isidentical

@hugovk hugovk

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @vkhodygo @hugovk @vstinner